Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG embedding + prepare for development #8

Merged
merged 7 commits into from Jan 21, 2022
Merged

Fix SVG embedding + prepare for development #8

merged 7 commits into from Jan 21, 2022

Commits on Jan 17, 2022

  1. assets: Fix unoptimized wedge 

    The viewbox caused the wedge to not render as expected when directly
embedded in the CSS.
    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    e905ea7 View commit details
    Browse the repository at this point in the history

  2. plugins: Add and include the file-reader plugin 

    This adds a less function that *directly* transcludes the content of a
file as a string.

In turn, this will be used to replace the clumsy SVG embedding during
the build process.
    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    03e7c13 View commit details
    Browse the repository at this point in the history

  3. Strip out the clumsy SVG embedding

    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    ce66256 View commit details
    Browse the repository at this point in the history

  4. svg.less: Use read-file 

    In addition, using `"g"` in `replace()` fixes a *well-hidden* set of
bugs where it was possible to miss replacements and actually have broken
results.
    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    bdf40a2 View commit details
    Browse the repository at this point in the history

  5. commonStyles: Optimize SVG files using svgo 

    Since we're not embedding clumsily anymore, we're not optimizing those
files eagerly anymore.

This shouldn't be an issue, as consumers *should* optimize SVG files,
but in the off chance they don't, let's optimize them eagerly again.
    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    9662603 View commit details
    Browse the repository at this point in the history

  6. commonStyles: Drop source SVG files from output

    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    196b18c View commit details
    Browse the repository at this point in the history

  7. doc: Document development use

    @samueldr
    samueldr committed Jan 17, 2022
    Copy the full SHA
    1a4f31d View commit details
    Browse the repository at this point in the history