Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenovo Legion 5 Pro 16ach6h breaks when using modesetting with current config #628

Closed
4JX opened this issue May 14, 2023 · 1 comment · Fixed by #841
Closed

Lenovo Legion 5 Pro 16ach6h breaks when using modesetting with current config #628

4JX opened this issue May 14, 2023 · 1 comment · Fixed by #841

Comments

@4JX
Copy link
Contributor

4JX commented May 14, 2023

Opening this up to see how to go about fixing it.

The commit 630a8e3 switched the default AMD driver from amdgpu to modesetting. When updating past this commit Xorg does not boot up correctly on my machine in hybrid/offload mode: https://gist.github.com/4JX/37d35bf95970f96ad341658da7af0ecd, with the Xorg config that is created being https://gist.github.com/4JX/ec3b37198fdc5900ac258ca99ce0e068.

If I manually remove the layout/device/screen referencing amdgpu (Created due to the presence of hardware.nvidia.prime.amdgpuBusId. Where any duplicate entries for drivers, from both amdgpu or modesetting, that will eventually end up controlling the iGPU trigger this issue if at least one of them uses the modesetting driver.) and move the BusID to the modesetting section (not necessary, there for redundancy) it boots up just fine.

I'm not sure if a proper fix would be to just tell it to use the amdgpu driver for my device, as it seems that the NixOS option is also to blame (it only considers modesetting for intel cards despite the move towards ditching the other drivers NixOS/nixpkgs#218437).

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/fetchurl-or-similar-as-a-way-of-getting-an-alert-if-something-changes-upstream/28726/3

4JX added a commit to 4JX/nixos-hardware that referenced this issue Jan 19, 2024
4JX added a commit to 4JX/nixos-hardware that referenced this issue Jan 19, 2024
4JX added a commit to 4JX/nixos-hardware that referenced this issue Jan 19, 2024
4JX added a commit to 4JX/nixos-hardware that referenced this issue Jan 19, 2024
@4JX 4JX mentioned this issue Jan 19, 2024
2 tasks
4JX added a commit to 4JX/nixos-hardware that referenced this issue Jan 19, 2024
@mergify mergify bot closed this as completed in #841 Feb 1, 2024
mergify bot pushed a commit that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants