pine64-pinebook-pro: remove superfluous bright/sleep keys #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream udev has had that since 2020: systemd/systemd@f25e30d
|
@tomfitzhenry I can't try this now but if you tested it and these keys work even without these lines I would say we can remove them. Anyway I've no idea why this was needed in the past and now is not needed anymore. |
|
Yes, I've tested this, and the brightness keys work. I expect this was once needed somewhere, before systemd/systemd@f25e30d had been committed/released. |
samueldr
approved these changes
Aug 10, 2022
tomfitzhenry
added a commit
to tomfitzhenry/nixos-hardware
that referenced
this pull request
Sep 29, 2023
2 tasks
Mic92
pushed a commit
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream udev has had that since 2020: systemd/systemd@f25e30d
Tested on my Pinebook Pro. Brightness keys still work.