Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pine64-pinebook-pro: remove inappropriate overriding of min_freq #445

Merged
merged 1 commit into from Aug 12, 2022
Merged

pine64-pinebook-pro: remove inappropriate overriding of min_freq #445

merged 1 commit into from Aug 12, 2022

Conversation

tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Aug 10, 2022

Power management should be left to a power management daemon (e.g. gnome-power-manager) or for users to set/override themselves (e.g. by setting a CPU governor).

I use governor 'schedutil', which is big.LITTLE aware, and thus can sensibly downclock, but min_freq prevents that.

Power management should be left to a power management daemon (e.g. gnome-power-manager) or for users to set/override themselves.

I use governor 'schedutil', which is big.LITTLE aware, and thus can sensibly downclock, but min_freq prevents that.
@tomfitzhenry
Copy link
Contributor Author

cc @aciceri @samueldr

@aciceri
Copy link
Member

aciceri commented Aug 10, 2022

It makes sense to me, consider that the original wip-pinebook-pro is deliberately opinionated. Anyway I see that this is still done by Elementary OS, do you say we should leave a note in the README with written that these settings could be useful if one is not using a power management daemon?

@samueldr
Copy link
Member

Makes sense, but also would invite discussion about how to expose such settings as a user-friendly way for systems builds where there is no userspace component to manage this.

As @aciceri said, this comes from my opinionated config.

This is also missing a detail about how I'm using the OP1 OPPs, basically overclocking/re-clocking the RK3399 in the Pinebook Pro [it actually adds an additional step]. So it's not even the complete view of the problem.

@tomfitzhenry
Copy link
Contributor Author

Setting powerManagement.cpuFreqGovernor is a simple and effective way to control power management, e.g. powersave or performance. Shall I add that to the README?

@Mic92 Mic92 merged commit 4387a4b into NixOS:master Aug 12, 2022
@Mic92
Copy link
Member

Mic92 commented Aug 12, 2022

Setting powerManagement.cpuFreqGovernor is a simple and effective way to control power management, e.g. powersave or performance. Shall I add that to the README?

I don't think this is needed unless specific quirks are needed for this device. This is a common interface used in many places.

tomfitzhenry added a commit to tomfitzhenry/nixos-hardware that referenced this pull request Sep 29, 2023
Mic92 pushed a commit that referenced this pull request Oct 1, 2023
Prior contributions:

* #444
* #445
* #446

Pending contributions:

* #743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants