Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 20.09 channel #416

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Drop 20.09 channel #416

merged 1 commit into from
Jan 17, 2022

Conversation

ncfavier
Copy link
Member

Since it has reached the end of its support lifetime and is not being updated anymore.

@ncfavier ncfavier requested a review from garbas January 17, 2022 11:27
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request January 17, 2022 11:29 Inactive
@ncfavier
Copy link
Member Author

I don't understand what this list is for, or why there's a 21.09 in there:

nixos-search/src/Search.elm

Lines 589 to 615 in f31e580

flakes =
[ { id = "latest-nixos-21.11-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.11"
, source = ""
}
, { id = "latest-nixos-21.05-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.05"
, source = ""
}
, { id = "nixos-21.09-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.09"
, source = ""
}
, { id = "latest-nixos-unstable"
, isNixpkgs = True
, title = "Nixpkgs Unstable"
, source = ""
}
, { id = "flakes"
, isNixpkgs = False
, title = "Public Flakes"
, source = ""
}
]

@garbas
Copy link
Member

garbas commented Jan 17, 2022

I don't understand what this list is for, or why there's a 21.09 in there:

nixos-search/src/Search.elm

Lines 589 to 615 in f31e580

flakes =
[ { id = "latest-nixos-21.11-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.11"
, source = ""
}
, { id = "latest-nixos-21.05-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.05"
, source = ""
}
, { id = "nixos-21.09-latest"
, isNixpkgs = True
, title = "Nixpkgs 21.09"
, source = ""
}
, { id = "latest-nixos-unstable"
, isNixpkgs = True
, title = "Nixpkgs Unstable"
, source = ""
}
, { id = "flakes"
, isNixpkgs = False
, title = "Public Flakes"
, source = ""
}
]

I think this is something @ysndr added when trying to use flakes backend for nixpkgs as well. I think we should at least comment this portion out if not remove it completely.

@ysndr what do you think?

@ncfavier
Copy link
Member Author

Merging now, I'll leave it to him for another PR.

@ncfavier ncfavier merged commit 5a40a2c into main Jan 17, 2022
@ncfavier ncfavier deleted the drop-20-09 branch January 17, 2022 22:28
@ysndr
Copy link
Member

ysndr commented Jan 18, 2022

The flakes were designed to be grouped with groups for the nixpkgs versions
Yet we decided to keep nixpkgs separate what is left is different groups in the front end code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants