This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
systemd: check service.name.Type and service.name.Restart #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let val = getAttr name attr; | ||
| in optional ( hasAttr name attr && !elem val values) "${name} ${val} not known to systemd"; | ||
| checkType = assertValueOneOf "Type" ["simple" "forking" "oneshot" "dbus" "notify" "idle"]; | ||
| checkRestart = assertValueOneOf "Restart" ["no" "on-success" "on-failure" "on-abort" "always"]; |
There was a problem hiding this comment.
This sounds to me that we should make a type of of this and enable the syntax:
type = types.attrsOf {
Type = types.anyOf ["simple" "forking" …];
Restart = types.anyOf ["no" "on-success" …];
};
what do you think?
There was a problem hiding this comment.
Keep in mind that you may want to check both: mandatory and optional names. That's why mkOption would be a bad option here. Except that types.attrsOf sounds like a good idea - if its documented properly :)
|
Any objections to merging the original proposal for now? |
ghost
assigned
|
cherry-picked to avoid ugly branch mess: d97ea69 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.