Skip to content

Commit

Permalink
chromium: Cleanup useOzone and useVaapi
Browse files Browse the repository at this point in the history
But since Ozone is still experimental I'll keep useOzone in common.nix
for some time.
  • Loading branch information
primeos committed Nov 27, 2020
1 parent ab61f16 commit 063b369
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
16 changes: 4 additions & 12 deletions pkgs/applications/networking/browsers/chromium/common.nix
Expand Up @@ -18,20 +18,14 @@
, ffmpeg, libxslt, libxml2, at-spi2-core
, jre8
, pipewire_0_2
, libva

# optional dependencies
, libgcrypt ? null # gnomeSupport || cupsSupport
, libva ? null # useVaapi
, libdrm ? null, wayland ? null, mesa ? null, libxkbcommon ? null # useOzone

# package customization
, useOzone ? false
, useVaapi ? !(useOzone || stdenv.isAarch64) # Built if supported, but disabled in the wrapper
# VA-API TODOs:
# - Ozone: M81 fails to build due to "ozone_platform_gbm = false"
# - Possible solutions: Write a patch to fix the build (wrong gn dependencies)
# or build with minigbm
# - AArch64: Causes serious regressions (https://github.com/NixOS/nixpkgs/pull/85253#issuecomment-614405879)
, useOzone ? true
, gnomeSupport ? false, gnome ? null
, gnomeKeyringSupport ? false, libgnome-keyring3 ? null
, proprietaryCodecs ? true
Expand Down Expand Up @@ -141,8 +135,8 @@ let
pciutils protobuf speechd libXdamage at-spi2-core
jre
pipewire_0_2
] ++ optional useVaapi libva
++ optional gnomeKeyringSupport libgnome-keyring3
libva
] ++ optional gnomeKeyringSupport libgnome-keyring3
++ optionals gnomeSupport [ gnome.GConf libgcrypt ]
++ optionals cupsSupport [ libgcrypt cups ]
++ optional pulseSupport libpulseaudio
Expand Down Expand Up @@ -256,8 +250,6 @@ let
proprietary_codecs = true;
enable_hangout_services_extension = true;
ffmpeg_branding = "Chrome";
} // optionalAttrs useVaapi {
use_vaapi = true;
} // optionalAttrs pulseSupport {
use_pulseaudio = true;
link_pulseaudio = true;
Expand Down
5 changes: 1 addition & 4 deletions pkgs/applications/networking/browsers/chromium/default.nix
Expand Up @@ -15,7 +15,6 @@
, enablePepperFlash ? false
, enableWideVine ? false
, enableVaapi ? false # Disabled by default due to unofficial support
, useOzone ? true
, cupsSupport ? true
, pulseSupport ? config.pulseaudio or stdenv.isLinux
, commandLineArgs ? ""
Expand All @@ -34,15 +33,13 @@ let

mkChromiumDerivation = callPackage ./common.nix ({
inherit channel gnome gnomeSupport gnomeKeyringSupport proprietaryCodecs
cupsSupport pulseSupport useOzone;
cupsSupport pulseSupport;
gnChromium = gn.overrideAttrs (oldAttrs: {
inherit (upstream-info.deps.gn) version;
src = fetchgit {
inherit (upstream-info.deps.gn) url rev sha256;
};
});
# TODO: Cleanup useOzone and useVaapi in common.nix:
useVaapi = !stdenv.isAarch64; # TODO: Might be best to not set use_vaapi anymore (default is fine)
});

browser = callPackage ./browser.nix { inherit channel enableWideVine; };
Expand Down

0 comments on commit 063b369

Please sign in to comment.