Skip to content

Commit

Permalink
cjdns: Disable tests
Browse files Browse the repository at this point in the history 
Since 8180922, the cjdns module
imports from a derivation, which is very bad. It causes all of stdenv
to be built at evaluation time. Since we have a hard 3600 second limit
on Hydra evaluations, this was causing NixOS jobsets to time out.

@joachifm
  • Loading branch information
@edolstra
edolstra committed Nov 8, 2016
1 parent 4d0bba1 commit 0ba3d42
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nixos/release.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ in rec {
tests.boot-stage1 = callTest tests/boot-stage1.nix {};
tests.cadvisor = hydraJob (import tests/cadvisor.nix { system = "x86_64-linux"; });
tests.chromium = (callSubTests tests/chromium.nix { system = "x86_64-linux"; }).stable;
tests.cjdns = callTest tests/cjdns.nix {};
#tests.cjdns = callTest tests/cjdns.nix {};
tests.containers-ipv4 = callTest tests/containers-ipv4.nix {};
tests.containers-ipv6 = callTest tests/containers-ipv6.nix {};
tests.containers-bridge = callTest tests/containers-bridge.nix {};
Expand Down

6 comments on commit 0ba3d42

@joachifm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edolstra Not that it matters, but it always imported from a derivation

@joachifm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edolstra the real culprit is daf3ba4 which caused that code path to be exercised by the test, whereas it would not before. An alternative to disabling the test would be to simply revert that change.

@edolstra
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. Yeah, that would be fine.

@joachifm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've made a note to do the reverts at some point.

Is there a way to add new hosts entries at run-time? That'd obviate the need for awkwardly appending to extraHosts at build time, we could instead emit a script with the appropriate calls.

@spacekitteh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjdelisle ?

@cjdelisle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tests that I've never seen... BTW THANKS FOR TESTING 😄
For me as long as the build tests are run (and ./do runs them) things are ok. Those tests are super quick but they validate that the crypto algorithms built correctly on the given hardware.

Please sign in to comment.