Skip to content

Commit

Permalink
binutils: patch bugs in 2.29
Browse files Browse the repository at this point in the history 
All are upstream patches, the last two added by handy to work around
them not applying on the changelog.

2.29.1/2.30 will contain the fixes, too.
  • Loading branch information
@globin
globin committed Aug 4, 2017
1 parent 2d64d1e commit 0e18f28
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pkgs/development/tools/misc/binutils/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ stdenv.mkDerivation rec {
# there) and causes a cycle between the lib and bin outputs, so
# get rid of it.
./no-plugins.patch

# remove after 2.29.1/2.30
(fetchurl {
url = "https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=patch;h=c6b78c965a96fb152fbd58926edccb5dee2707a5";
sha256 = "0rkbq5pf7ffgcggfk4czkxin1091bqjj92an9wxnqkgqwq6cx5yr";
name = "readelf-empty-sections.patch";
})
./elf-check-orphan-input.patch

This comment has been minimized.

Sign in to view

Copy link
@Mic92

Mic92 Aug 5, 2017

Member

btw. there is fetchpatch { excludes = ["somefile"]; }; to skip changelog

This comment has been minimized.

Sign in to view

Copy link
@globin

globin Aug 5, 2017

Author Member

I know, I built that, but we can't use that in the stdenv.

This comment has been minimized.

Sign in to view

Copy link
@dezgeg

dezgeg Aug 14, 2017 •
edited

Contributor

It doesn't inspire confidence in me that this new binutils release is so buggy that it seemingly requires three patches just to work. In addition aarch64 bootstrap building is broken (#28257) and IIRC, armv7 totally broken (after double-checking it's something else).

Should we revert? Even Arch Linux hasn't dared to upgrade.

This comment has been minimized.

Sign in to view

Copy link
@edolstra

edolstra Aug 14, 2017

Member

In my experience, binutils upgrades tend to cause so much breakage that (like with gcc) it's best to wait at least a few months before upgrading. (We waited four year for the 2.26 upgrade...)

This comment has been minimized.

Sign in to view

Copy link
@vcunat

vcunat Aug 16, 2017

Member

So, downgrade to 2.28.1? It was released just after 2.29 and I'd hope it isn't more buggy than 2.28 which we had before.

This comment has been minimized.

Sign in to view

Copy link
@dezgeg

dezgeg Aug 16, 2017

Contributor

I can give that a try.

This comment has been minimized.

Sign in to view

Copy link
@vcunat

vcunat Aug 17, 2017

Member

I built roughly a hundred packages on x86_64-linux without noticing a problem. I removed the three patches; I'm not sure if they patched a bug that isn't present in 2.28.1 or if we had some "test" it broke.

https://github.com/vcunat/nixpkgs/commits/p/binutils-downgrade

This comment has been minimized.

Sign in to view

Copy link
@dezgeg

dezgeg Aug 18, 2017

Contributor

Yeah, the aarch64 thing on 2.28.1 worked for me (staging...dezgeg:downgrade-binutils is what I ended up with), plus an unrelated fix for ARMv7.

This comment has been minimized.

Sign in to view

Copy link
@fpletz

fpletz Aug 18, 2017

Member

Thanks for testing, downgrade makes sense for now and for 17.09. 👍

This comment has been minimized.

Sign in to view

Copy link
@vcunat

vcunat Aug 18, 2017

Member

Staged as 6a60cca.
./elf-check-orphan-placement.patch
];

# TODO: all outputs on all platform
Expand Down

0 comments on commit 0e18f28

Please sign in to comment.