Skip to content

Commit

Permalink
gcc, binutils: Get rid of 32-bit ARM configure flag exception
Browse files Browse the repository at this point in the history
Now that we do `--enable-targes=all`, there is no risk of missing the
needed emulation.

This reverts commit ebc9b16.
This reverts commit 88efc22.
  • Loading branch information
Ericson2314 committed Dec 31, 2017
1 parent 9cda2f5 commit 0f5c804
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 40 deletions.
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/4.5/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,7 @@ stdenv.mkDerivation ({
;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/4.8/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/4.9/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/5/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/6/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/7/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/compilers/gcc/snapshot/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,7 @@ stdenv.mkDerivation ({
dontDisableStatic = true;

# TODO(@Ericson2314): Always pass "--target" and always prefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags =
# Basic dependencies
Expand Down
6 changes: 1 addition & 5 deletions pkgs/development/tools/misc/binutils/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@ stdenv.mkDerivation rec {
else "-static-libgcc";

# TODO(@Ericson2314): Always pass "--target" and always targetPrefix.
configurePlatforms =
# TODO(@Ericson2314): Figure out what's going wrong with Arm
if hostPlatform == targetPlatform && targetPlatform.isArm
then []
else [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";
configurePlatforms = [ "build" "host" ] ++ stdenv.lib.optional (targetPlatform != hostPlatform) "target";

configureFlags = [
"--enable-targets=all" "--enable-64-bit-bfd"
Expand Down

0 comments on commit 0f5c804

Please sign in to comment.