Skip to content

Commit

Permalink
edk2: Reformat a bit for readability
Browse files Browse the repository at this point in the history
- Have only one sed expression per line
- Put the important stuff closer to the command and not hidden in some
continuation line. That is, don't do:

sed \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <IMPORTANT STUFF>

but:

sed <IMPORTANT STUFF> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff>
  • Loading branch information
dezgeg committed Mar 21, 2018
1 parent 044d4b0 commit 1d854b4
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions pkgs/development/compilers/edk2/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,20 @@ edk2 = stdenv.mkDerivation {

configurePhase = ''
mkdir -v Conf
sed -e 's|Nt32Pkg/Nt32Pkg.dsc|${projectDscPath}|' -e \
's|MYTOOLS|GCC49|' -e 's|IA32|${targetArch}|' -e 's|DEBUG|RELEASE|'\
< ${edk2}/BaseTools/Conf/target.template > Conf/target.txt
sed -e 's|DEFINE GCC48_IA32_PREFIX = /usr/bin/|DEFINE GCC48_IA32_PREFIX = ""|' \
cp ${edk2}/BaseTools/Conf/target.template Conf/target.txt
sed -i Conf/target.txt \
-e 's|Nt32Pkg/Nt32Pkg.dsc|${projectDscPath}|' \
-e 's|MYTOOLS|GCC49|' \
-e 's|IA32|${targetArch}|' \
-e 's|DEBUG|RELEASE|'\
cp ${edk2}/BaseTools/Conf/tools_def.template Conf/tools_def.txt
sed -i Conf/tools_def.txt \
-e 's|DEFINE GCC48_IA32_PREFIX = /usr/bin/|DEFINE GCC48_IA32_PREFIX = ""|' \
-e 's|DEFINE GCC48_X64_PREFIX = /usr/bin/|DEFINE GCC48_X64_PREFIX = ""|' \
-e 's|DEFINE UNIX_IASL_BIN = /usr/bin/iasl|DEFINE UNIX_IASL_BIN = ${iasl}/bin/iasl|' \
< ${edk2}/BaseTools/Conf/tools_def.template > Conf/tools_def.txt
-e 's|DEFINE UNIX_IASL_BIN = /usr/bin/iasl|DEFINE UNIX_IASL_BIN = ${iasl}/bin/iasl|'
export WORKSPACE="$PWD"
export EFI_SOURCE="$PWD/EdkCompatibilityPkg"
ln -sv ${edk2}/BaseTools BaseTools
Expand Down

0 comments on commit 1d854b4

Please sign in to comment.