Skip to content

Commit

Permalink
Merge #250128: bash: disable bash-malloc everywhere
Browse files Browse the repository at this point in the history
...into staging
  • Loading branch information
vcunat committed Sep 16, 2023
2 parents 3d5e8ad + 8708ae0 commit 223b83c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkgs/shells/bash/5.nix
Expand Up @@ -68,6 +68,12 @@ stdenv.mkDerivation rec {
];

configureFlags = [
# At least on Linux bash memory allocator has pathological performance
# in scenarios involving use of larger memory:
# https://lists.gnu.org/archive/html/bug-bash/2023-08/msg00052.html
# Various distributions default to system allocator. Let's nixpkgs
# do the same.
"--without-bash-malloc"
(if interactive then "--with-installed-readline" else "--disable-readline")
] ++ lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [
"bash_cv_job_control_missing=nomissing"
Expand All @@ -81,7 +87,6 @@ stdenv.mkDerivation rec {
"bash_cv_dev_fd=standard"
"bash_cv_termcap_lib=libncurses"
] ++ lib.optionals (stdenv.hostPlatform.libc == "musl") [
"--without-bash-malloc"
"--disable-nls"
];

Expand Down

0 comments on commit 223b83c

Please sign in to comment.