Skip to content

Commit

Permalink
nomad: Pin to go1.14 for 0.11 and 0.12
Browse files Browse the repository at this point in the history
This commit pins go versions for nomad 0.11 and 0.12. Future versions of
Nomad should have their versions pinned from the beginning, even if they
support the latest-at-the-time version of Go to prevent accidental
version bumps on unsupported go versions.

See #96414 for further discussion
around this change.
  • Loading branch information
endocrimes committed Sep 9, 2020
1 parent 168a85b commit 329a922
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
3 changes: 2 additions & 1 deletion pkgs/applications/networking/cluster/nomad/0.11.nix
@@ -1,6 +1,7 @@
{ callPackage }:
{ callPackage, buildGoPackage }:

callPackage ./generic.nix {
inherit buildGoPackage;
version = "0.11.4";
sha256 = "1sykp9sji6f564s7bz0cvnr9w5x92n0l1r1djf1bl7jvv2mi1mcb";
}
3 changes: 2 additions & 1 deletion pkgs/applications/networking/cluster/nomad/0.12.nix
@@ -1,6 +1,7 @@
{ callPackage }:
{ callPackage, buildGoPackage }:

callPackage ./generic.nix {
inherit buildGoPackage;
version = "0.12.3";
sha256 = "100ynhc4nm4mmjxx1jhq2kjbqshxvi5x8y482520j8gsyn40g6zc";
}
11 changes: 9 additions & 2 deletions pkgs/top-level/all-packages.nix
Expand Up @@ -5687,8 +5687,15 @@ in
noip = callPackage ../tools/networking/noip { };

nomad = nomad_0_11;
nomad_0_11 = callPackage ../applications/networking/cluster/nomad/0.11.nix { };
nomad_0_12 = callPackage ../applications/networking/cluster/nomad/0.12.nix { };
# Nomad never updates major go versions within a release series and is unsupported
# on Go versions that it did not ship with. Due to historic bugs when compiled
# with different versions we pin Go for all versions.
nomad_0_11 = callPackage ../applications/networking/cluster/nomad/0.11.nix {
buildGoPackage = buildGo114Package;
};
nomad_0_12 = callPackage ../applications/networking/cluster/nomad/0.12.nix {
buildGoPackage = buildGo114Package;
};

notable = callPackage ../applications/misc/notable { };

Expand Down

0 comments on commit 329a922

Please sign in to comment.