Skip to content

Commit

Permalink
release.nix: resurrect stdenvBootstrapTools
Browse files Browse the repository at this point in the history
13d6681 crippled it unintentionally.
Also remove the incorrect/non-existing stdenv.i686-linux;
building the bootstrap tools should be a good-enough test anyway.
  • Loading branch information
vcunat committed Aug 6, 2017
1 parent 145be4e commit 332a60c
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions pkgs/top-level/release.nix
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ let
jobs.manual
jobs.lib-tests
jobs.stdenv.x86_64-linux
jobs.stdenv.i686-linux # most basic sanity check
jobs.stdenv.x86_64-darwin
jobs.linux.x86_64-linux
jobs.python.x86_64-linux
Expand All @@ -79,26 +78,27 @@ let
jobs.vim.x86_64-darwin
] ++ lib.collect lib.isDerivation jobs.stdenvBootstrapTools;
};
} // (lib.optionalAttrs (builtins.elem "i686-linux" systemsWithAnySupport) {
stdenvBootstrapTools.i686-linux =
{ inherit (import ../stdenv/linux/make-bootstrap-tools.nix { system = "i686-linux"; }) dist test; };
}) // (lib.optionalAttrs (builtins.elem "x86_64-linux" systemsWithAnySupport) {
stdenvBootstrapTools.x86_64-linux =
{ inherit (import ../stdenv/linux/make-bootstrap-tools.nix { system = "x86_64-linux"; }) dist test; };
}) // (lib.optionalAttrs (builtins.elem "aarch64-linux" systemsWithAnySupport) {
stdenvBootstrapTools.aarch64-linux =
{ inherit (import ../stdenv/linux/make-bootstrap-tools.nix { system = "aarch64-linux"; }) dist test; };
}) // (lib.optionalAttrs (builtins.elem "x86_64-darwin" systemsWithAnySupport) {
stdenvBootstrapTools.x86_64-darwin =
let
bootstrap = import ../stdenv/darwin/make-bootstrap-tools.nix { system = "x86_64-darwin"; };
in {
# Lightweight distribution and test
inherit (bootstrap) dist test;
# Test a full stdenv bootstrap from the bootstrap tools definition
inherit (bootstrap.test-pkgs) stdenv;
};
}) // (mapTestOn ((packagePlatforms pkgs) // rec {

stdenvBootstrapTools = with lib;
genAttrs systemsWithAnySupport
(system: {
inherit (import ../stdenv/linux/make-bootstrap-tools.nix { inherit system; })
dist test;
})
# darwin is special in this
// optionalAttrs (builtins.elem "x86_64-darwin" systemsWithAnySupport) {
x86_64-darwin =
let
bootstrap = import ../stdenv/darwin/make-bootstrap-tools.nix { system = "x86_64-darwin"; };
in {
# Lightweight distribution and test
inherit (bootstrap) dist test;
# Test a full stdenv bootstrap from the bootstrap tools definition
inherit (bootstrap.test-pkgs) stdenv;
};
};

} // (mapTestOn ((packagePlatforms pkgs) // rec {
haskell.compiler = packagePlatforms pkgs.haskell.compiler;
haskellPackages = packagePlatforms pkgs.haskellPackages;

Expand Down

3 comments on commit 332a60c

@jtojnar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am reading it correctly, this commit broke unstable:

First broken build 2017-08-06 13:28:10 build 58163964

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 332a60c Aug 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that depends on your point of view :-) This commit resurrected builds that have been left unintentionally untested; they were broken before but Hydra just never checked...

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 332a60c Aug 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion continued on #27746 (comment)

Please sign in to comment.