Skip to content

Commit

Permalink
Merge pull request #80940 from veprbl/pr/ipykernel_darwin_fix2
Browse files Browse the repository at this point in the history
python3Packages.ipykernel: fix build on darwin
  • Loading branch information
veprbl committed Mar 3, 2020
2 parents fa2546f + d35009e commit 344d914
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions pkgs/development/python-modules/ipykernel/default.nix
Expand Up @@ -16,7 +16,6 @@
buildPythonPackage rec {
pname = "ipykernel";
version = "5.1.4";
disabled = pythonOlder "3.4";

src = fetchPypi {
inherit pname version;
Expand All @@ -38,12 +37,23 @@ buildPythonPackage rec {
preCheck = ''
export HOME=$(mktemp -d)
'';
disabledTests = lib.optionals stdenv.isDarwin [
disabledTests = lib.optionals stdenv.isDarwin ([
# see https://github.com/NixOS/nixpkgs/issues/76197
"test_subprocess_print"
"test_subprocess_error"
"test_ipython_start_kernel_no_userns"
];
] ++ lib.optionals (pythonOlder "3.8") [
# flaky test https://github.com/ipython/ipykernel/issues/485
"test_shutdown"

# test regression https://github.com/ipython/ipykernel/issues/486
"test_sys_path_profile_dir"
"test_save_history"
"test_help_output"
"test_write_kernel_spec"
"test_ipython_start_kernel_userns"
"ZMQDisplayPublisherTests"
]);

# Some of the tests use localhost networking.
__darwinAllowLocalNetworking = true;
Expand Down

0 comments on commit 344d914

Please sign in to comment.