Skip to content

Commit

Permalink
nixos.pulseaudio: Remove bad recommendation to use pulseaudio in syst…
Browse files Browse the repository at this point in the history 
…em-wide mode

Upstream Pulseaudio has always stated that system-wide is not
recommended and comes with a number of usability and security drawbacks.
  • Loading branch information
@adisbladis
adisbladis committed Oct 30, 2019
1 parent e4c34f2 commit 3af4f88
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions nixos/modules/config/pulseaudio.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,12 @@ in {
description = ''
If false, a PulseAudio server is launched automatically for
each user that tries to use the sound system. The server runs
with user privileges. This is the recommended and most secure
way to use PulseAudio. If true, one system-wide PulseAudio
with user privileges. If true, one system-wide PulseAudio
server is launched on boot, running as the user "pulse", and
only users in the "audio" group will have access to the server.
Please read the PulseAudio documentation for more details.
Don't enable this option unless you know what you are doing.
'';
};

Expand Down

3 comments on commit 3af4f88

@herrwiese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To take up the cudgels for the original author: IMHO this is exactly what the paragraph stated in the first place — »This is recommended« refers to the previous sentence(s): »If false, […] the server runs with user privileges. This is the recommended and most secure way to use PulseAudio.«

@adisbladis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herrwiese The parsing of the previous sentence was ambiguous then. I and many others with me was parsing it as systemWide was the recommended approach.

The current wording is much less ambiguous and clearly points out that this is not the recommended way to use PA.

@herrwiese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record. ;) Though on first reading this change (a while back), I almost would have voted for reverting because I didn't notice the added last sentence and thought it quite dangerous to drop the warning altogether (what you didn't do). With that included it's quite more clear now, indeed.

Please sign in to comment.