Skip to content

Commit

Permalink
Revert "diffoscope: wrap executable and include tools in PATH"
Browse files Browse the repository at this point in the history
This reverts commit 23ad77b.

Double wrapper scripts considered harmful.
  • Loading branch information
edolstra committed Jul 21, 2017
1 parent d0bcb41 commit 3e68fac
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions pkgs/tools/misc/diffoscope/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,7 @@
, enableBloat ? false
}:

# Still missing these tools: enjarify, otool & lipo (maybe OS X only), showttf
# Also these libraries: python3-guestfs
# FIXME: move xxd into a separate package so we don't have to pull in all of vim.
let tools = [ acl binutils bzip2 cbfstool cdrkit cpio diffutils e2fsprogs file gettext
gzip libcaca poppler_utils sng sqlite squashfsTools unzip vim xz colordiff
] ++ lib.optionals enableBloat [ colord fpc ghc gnupg1 jdk mono pdftk ];
in python3.pkgs.buildPythonApplication rec {
python3.pkgs.buildPythonApplication rec {
pname = "diffoscope";
name = "${pname}-${version}";
version = "77";
Expand All @@ -32,14 +26,21 @@ in python3.pkgs.buildPythonApplication rec {
sed -i setup.py -e "/'rpm-python',/d"
'';

# Still missing these tools: enjarify, otool & lipo (maybe OS X only), showttf
# Also these libraries: python3-guestfs
# FIXME: move xxd into a separate package so we don't have to pull in all of vim.
buildInputs =
map lib.getBin ([ acl binutils bzip2 cbfstool cdrkit cpio diffutils e2fsprogs file gettext
gzip libcaca poppler_utils sng sqlite squashfsTools unzip vim xz colordiff
] ++ lib.optionals enableBloat [ colord fpc ghc gnupg1 jdk mono pdftk ]);

pythonPath = with python3.pkgs; [ debian libarchive-c python_magic tlsh rpm ];

doCheck = false; # Calls 'mknod' in squashfs tests, which needs root

postInstall = ''
mkdir -p $out/share/man/man1
${docutils}/bin/rst2man.py debian/diffoscope.1.rst $out/share/man/man1/diffoscope.1
wrapProgram $out/bin/diffoscope --prefix PATH : ${lib.makeBinPath tools}
'';

meta = with stdenv.lib; {
Expand Down

0 comments on commit 3e68fac

Please sign in to comment.