Skip to content

Commit

Permalink
linux: avoid memory hotplug support on most platforms
Browse files Browse the repository at this point in the history
It broke i686 build, and it's probably not worth it on others, too.
/cc #54095 e634140.
  • Loading branch information
vcunat committed Jan 19, 2019
1 parent 0bf9656 commit 3fa7729
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/os-specific/linux/kernel/common-config.nix
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,7 @@ let
HOTPLUG_PCI_ACPI = yes; # PCI hotplug using ACPI
HOTPLUG_PCI_PCIE = yes; # PCI-Expresscard hotplug support

} // optionalAttrs (stdenv.hostPlatform.system == "x86_64-linux" || stdenv.hostPlatform.system == "aarch64-linux") {
# Enable memory hotplug support
# Allows you to dynamically add & remove memory to a VM client running NixOS without requiring a reboot
ACPI_HOTPLUG_MEMORY = yes;
Expand All @@ -695,7 +696,6 @@ let
MIGRATION = yes;
SPARSEMEM = yes;

} // optionalAttrs (stdenv.hostPlatform.system == "x86_64-linux" || stdenv.hostPlatform.system == "aarch64-linux") {
# Bump the maximum number of CPUs to support systems like EC2 x1.*
# instances and Xeon Phi.
NR_CPUS = "384";
Expand Down

0 comments on commit 3fa7729

Please sign in to comment.