Skip to content

Commit

Permalink
Use span instead of a for inline span syntax
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielSidhion committed Mar 16, 2024
1 parent 4291bac commit 42e3431
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def attr_span_begin(self, token: Token, tokens: Sequence[Token], i: int) -> str:
# keycap-styled spans.
(id_part, class_part) = ("", "")
if s := token.attrs.get('id'):
id_part = f'<a id="{escape(cast(str, s), True)}"></a>'
id_part = f'<span id="{escape(cast(str, s), True)}"></span>'
if s := token.attrs.get('class'):
if s == 'keycap':
class_part = '<span class="keycap"><strong>'
Expand All @@ -181,7 +181,7 @@ def heading_open(self, token: Token, tokens: Sequence[Token], i: int) -> str:
if hstyle:
hstyle = f'style="{escape(hstyle, True)}"'
if anchor := cast(str, token.attrs.get('id', '')):
anchor = f'<a id="{escape(anchor, True)}"></a>'
anchor = f'<span id="{escape(anchor, True)}"></span>'
result = self._close_headings(hlevel)
tag = self._heading_tag(token, tokens, i)
toc_fragment = self._build_toc(tokens, i)
Expand Down Expand Up @@ -220,7 +220,7 @@ def ordered_list_close(self, token: Token, tokens: Sequence[Token], i: int) -> s
def example_open(self, token: Token, tokens: Sequence[Token], i: int) -> str:
if id := cast(str, token.attrs.get('id', '')):
id = f'id="{escape(id, True)}"' if id else ''
return f'<div class="example"><a {id} ></a>'
return f'<div class="example"><span {id} ></span>'
def example_close(self, token: Token, tokens: Sequence[Token], i: int) -> str:
return '</div></div><br class="example-break" />'
def example_title_open(self, token: Token, tokens: Sequence[Token], i: int) -> str:
Expand All @@ -239,7 +239,7 @@ def image(self, token: Token, tokens: Sequence[Token], i: int) -> str:
)
def figure_open(self, token: Token, tokens: Sequence[Token], i: int) -> str:
if anchor := cast(str, token.attrs.get('id', '')):
anchor = f'<a id="{escape(anchor, True)}"></a>'
anchor = f'<span id="{escape(anchor, True)}"></span>'
return f'<div class="figure">{anchor}'
def figure_close(self, token: Token, tokens: Sequence[Token], i: int) -> str:
return (
Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/nix/nixos-render-docs/src/tests/test_html.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def test_full() -> None:
<span class="citerefentry"><span class="refentrytitle">man</span>(1)</span>
</a> reference
</p>
<p><a id="b"></a>some <a id="a"></a>nested anchors</p>
<p><span id="b"></span>some <span id="a"></span>nested anchors</p>
<p>
<span class="emphasis"><em>emph</em></span>␣
<span class="strong"><strong>strong</strong></span>␣
Expand Down

0 comments on commit 42e3431

Please sign in to comment.