Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dhcpcd service: order before network target
This reverts a change applied in PR #18491. When interfaces are configured by DHCP (typical in a cloud environment), ordering after network.target cause trouble to applications expecting some network to be present on boot (for example, cloud-init is quite brittle when network hasn't been configured for `cloud-init.service`) and on shutdown (for example, collectd needs to flush metrics on shutdown). When ordering after network.target, we ensure applications relying on network.target won't have any network reachability on boot and potentially on shutdown. Therefore, I think ordering before network.target is better.
- Loading branch information
48f7778
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this commit changes interface naming in the corresponding test, creating a channel blocker: https://hydra.nixos.org/job/nixos/unstable-small/nixos.tests.predictable-interface-names.predictable.x86_64-linux (there was one success on Hydra since, but did not manage to reproduce that one)