Skip to content

Commit

Permalink
netpbm: Fix a truly random build failure
Browse files Browse the repository at this point in the history
Since "src" is a fetchsvn directory, the source is copied with "cp
--no-preserve=timestamps" (see commit
6d928ab).  So some source files might
get a slightly different timestamp.  Here, if lib/standard.ppmdfont
gets a newer timestamp than the generated file lib/standardppmdfont.c,
Make will try to rebuild the latter.  But that fails because the
ppmdcfont program doesn't exist (yet).

Probably stdenv should ensure that every file has the same timestamp.
  • Loading branch information
edolstra committed Jul 23, 2013
1 parent bee4c41 commit 4dd9507
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkgs/tools/graphics/netpbm/default.nix
@@ -1,4 +1,4 @@
{stdenv, fetchsvn, pkgconfig, libjpeg, libpng, flex, zlib, perl, libxml2, makeWrapper, libX11, libtiff }:
{ stdenv, fetchsvn, pkgconfig, libjpeg, libpng, flex, zlib, perl, libxml2, makeWrapper, libX11, libtiff }:

let rev = 1742; in
stdenv.mkDerivation {
Expand Down Expand Up @@ -29,8 +29,11 @@ stdenv.mkDerivation {
--subst-var-by "rgbPath1" "$out/lib/rgb.txt" \
--subst-var-by "rgbPath2" "/var/empty/rgb.txt" \
--subst-var-by "rgbPath3" "/var/empty/rgb.txt"
touch lib/standardppmdfont.c
'';

enableParallelBuilding = true;

installPhase = ''
make package pkgdir=$PWD/netpbmpkg
# Pass answers to the script questions
Expand Down

0 comments on commit 4dd9507

Please sign in to comment.