Skip to content

Commit

Permalink
smartmontools: fix missing sed w/o enableMail
Browse files Browse the repository at this point in the history
Fixes #185095.

Added gnused to smartmontools regardless of `enableMail`.

The previous fix only works when `enableMail = true`.

Also fixing this while I'm at it:
```
warning: String 'configureFlags' is deprecated and will be removed in release 23.05. Please use a list of strings.
```
  • Loading branch information
hanleym authored and bjornfor committed Aug 23, 2022
1 parent 055ab52 commit 58e0d95
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkgs/tools/system/smartmontools/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ let
sha256 = "sha256-0dtLev4JjeHsS259+qOgg19rz4yjkeX4D3ooUgS4RTI=";
name = "smartmontools-drivedb.h";
};
scriptPath = lib.makeBinPath ([ gnused ] ++ lib.optional enableMail [ inetutils mailutils ]);

in
stdenv.mkDerivation rec {
Expand All @@ -37,7 +38,7 @@ stdenv.mkDerivation rec {
cp -v ${driverdb} drivedb.h
'';

configureFlags = lib.optional enableMail "--with-scriptpath=${lib.makeBinPath [ gnused inetutils mailutils ]}";
configureFlags = [ "--with-scriptpath=${scriptPath}" ];

nativeBuildInputs = [ autoreconfHook ];
buildInputs = lib.optionals stdenv.isDarwin [ IOKit ApplicationServices ];
Expand Down

0 comments on commit 58e0d95

Please sign in to comment.