Skip to content

Commit

Permalink
python.ftfy: 5.3.0 -> 4.4.3
Browse files Browse the repository at this point in the history
V5 only supports python3. Since at the moment the only packages
that use ftfy are spacy and textacy which both support
python2 and 3, I propose to roll back to v4 until another package
requires v5, at that point we can make a duplicate package.

(cherry picked from commit 8187d93)
  • Loading branch information
Augustin Borsu authored and Robert Schütz committed Mar 14, 2018
1 parent a268467 commit 6381f5a
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions pkgs/development/python-modules/ftfy/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,23 @@
, python
, isPy3k
}:

buildPythonPackage rec {
name = "${pname}-${version}";
pname = "ftfy";
# latest is 5.1.1, buy spaCy requires 4.4.3
version = "5.3.0";

version = "4.4.3";
# ftfy v5 only supports python3. Since at the moment the only
# packages that use ftfy are spacy and textacy which both support
# python 2 and 3, they have pinned ftfy to the v4 branch.
# I propose to stick to v4 until another package requires v5.
# At that point we can make a ftfy_v4 package.

src = fetchPypi {
inherit pname version;
sha256 = "0ba702d5138f9b35df32b55920c9466208608108f1f3d5de1a68c17e3d68cb7f";
sha256 = "152xdb56rhs1q4r0ck1n557sbphw7zq18r75a7kkd159ckdnc01w";
};

propagatedBuildInputs = [ html5lib wcwidth];
propagatedBuildInputs = [ html5lib wcwidth ];

checkInputs = [
nose
Expand All @@ -32,13 +37,10 @@ buildPythonPackage rec {
# FileNotFoundError: [Errno 2] No such file or directory: 'ftfy'
doCheck = false;

# "this version of ftfy is no longer written for Python 2"
disabled = !isPy3k;

meta = with stdenv.lib; {
description = "Given Unicode text, make its representation consistent and possibly less broken.";
homepage = https://github.com/LuminosoInsight/python-ftfy/tree/master/tests;
license = licenses.mit;
maintainers = with maintainers; [ sdll ];
};
maintainers = with maintainers; [ sdll aborsu ];
};
}

0 comments on commit 6381f5a

Please sign in to comment.