Skip to content

Commit

Permalink
emacs.pkgs.seq: stop shadowing it
Browse files Browse the repository at this point in the history
magit requires[1] seq 2.24.  seq from GNU Elpa satisfies that.
However, it is shadowed by the Emacs builtin one to workaround an old
bug[2] and the version of the builtin seq in Emacs 28 is only 2.23.
So magit is broken for Emacs 28 which is the default one in NixOS
23.11 and available in the unstable branch.

This patch fixes magit by stopping shadowing seq from GNU Elpa since
that old bug[2] is not relevant now.

Fixes #272019.

[1]: https://github.com/magit/magit/blob/f4ff817cb2a48f0f7887050c3be469c03a059567/lisp/magit.el#L27
[2]: #74936
  • Loading branch information
jian-lin committed Mar 2, 2024
1 parent 41e7732 commit 7374ffe
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ self: let
cl-print = null; # builtin
tle = null; # builtin
advice = null; # builtin
seq = if lib.versionAtLeast self.emacs.version "27"
then null
else super.seq;
# Compilation instructions for the Ada executables:
# https://www.nongnu.org/ada-mode/
ada-mode = super.ada-mode.overrideAttrs (old: {
Expand Down

0 comments on commit 7374ffe

Please sign in to comment.