Skip to content

Commit

Permalink
Merge pull request #119304 from primeos/chromium
Browse files Browse the repository at this point in the history
chromiumBeta: 90.0.4430.61 -> 90.0.4430.70
  • Loading branch information
primeos committed Apr 13, 2021
2 parents 8440454 + fc58686 commit 74df3bb
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 5 deletions.
8 changes: 6 additions & 2 deletions pkgs/applications/networking/browsers/chromium/common.nix
Expand Up @@ -7,7 +7,7 @@
, xdg-utils, yasm, nasm, minizip, libwebp
, libusb1, pciutils, nss, re2

, python2Packages, perl, pkg-config
, python2Packages, python3Packages, perl, pkg-config
, nspr, systemd, libkrb5
, util-linux, alsaLib
, bison, gperf
Expand Down Expand Up @@ -130,6 +130,8 @@ let
ninja which python2Packages.python perl pkg-config
python2Packages.ply python2Packages.jinja2 nodejs
gnutar python2Packages.setuptools
] ++ optionals (chromiumVersionAtLeast "91") [
python3Packages.python
];

buildInputs = defaultDependencies ++ [
Expand Down Expand Up @@ -160,7 +162,9 @@ let
url = "https://raw.githubusercontent.com/archlinux/svntogit-packages/61b0ab526d2aa3c62fa20bb756461ca9a482f6c6/trunk/chromium-fix-libva-redef.patch";
sha256 = "1qj4sn1ngz0p1l1w3346kanr1sqlr3xdzk1f1i86lqa45mhv77ny";
}) ++ optional (chromiumVersionAtLeast "90")
./fix-missing-atspi2-dependency.patch
./patches/fix-missing-atspi2-dependency.patch
++ optional (chromiumVersionAtLeast "91")
./patches/closure_compiler-Use-the-Java-binary-from-the-system.patch
;

postPatch = ''
Expand Down
@@ -0,0 +1,31 @@
From e031b8be0fb2a22f953c034cdf08ca9befe130d2 Mon Sep 17 00:00:00 2001
From: Michael Weiss <dev.primeos@gmail.com>
Date: Sun, 11 Apr 2021 18:05:12 +0200
Subject: [PATCH] closure_compiler: Use the Java binary from the system

The bundled Java binary (third_party/jdk/current/bin/java) is missing in
the tarball and we want to use the one from the system anyway.
This reverts part of [0].

[0]: https://chromium-review.googlesource.com/c/chromium/src/+/2778794
---
third_party/closure_compiler/compiler.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/third_party/closure_compiler/compiler.py b/third_party/closure_compiler/compiler.py
index 75690ceb9749..7b9c76f74290 100755
--- a/third_party/closure_compiler/compiler.py
+++ b/third_party/closure_compiler/compiler.py
@@ -13,8 +13,7 @@ import subprocess


_CURRENT_DIR = os.path.join(os.path.dirname(__file__))
-_JAVA_PATH = os.path.join(_CURRENT_DIR, "..", "jdk", "current", "bin", "java")
-assert os.path.isfile(_JAVA_PATH), "java only allowed in android builds"
+_JAVA_PATH = "java"

class Compiler(object):
"""Runs the Closure compiler on given source files to typecheck them
--
2.20.1

Expand Up @@ -18,9 +18,9 @@
}
},
"beta": {
"version": "90.0.4430.61",
"sha256": "01vssy3q64pv9rw4cdxv5rdg7yrxmhyc03a5r75fhxc95fj66iac",
"sha256bin64": "07l8dzyv0hav1gls3xw91q9ay2l8xxmsf7yagg940cya9ncl0lhi",
"version": "90.0.4430.70",
"sha256": "0jnyqnqwdccv3i55grd12wr2w5ffxyzmj2l3c1i24xawf2zdzyym",
"sha256bin64": "1lv9gz6llphyvlvn92yw1cyhj4i6jzhy1l7hk01418prmhb4nfws",
"deps": {
"gn": {
"version": "2021-02-09",
Expand Down

0 comments on commit 74df3bb

Please sign in to comment.