Skip to content

Commit

Permalink
pipenv: fix dependencies
Browse files Browse the repository at this point in the history
- setup_requires belong in nativeBuildInputs
- requests is only for Python 2. We offer only a Python 3 version of
pipenv
- setting PYTHONPATH is not needed because the magical sed expression
injects the dependencies in the executables. Otherwise, we would use
NIX_PYTHONPATH.
- PIP_IGNORE_INSTALLED was needed because of PYTHONPATH, but since we do
not set that anymore we can remove.
  • Loading branch information
FRidh authored and Jon committed Oct 22, 2019
1 parent 8310e64 commit 7f63ecf
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions pkgs/development/tools/pipenv/default.nix
@@ -1,6 +1,7 @@
{ lib
, buildPythonApplication
, flake8
, certifi
, setuptools
, invoke
, parver
, pip
Expand All @@ -21,23 +22,18 @@ buildPythonApplication rec {

LC_ALL = "en_US.UTF-8";

nativeBuildInputs = [ invoke parver ];

propagatedBuildInputs = [
flake8
invoke
parver
certifi
setuptools
pip
requests
virtualenv
virtualenv-clone
];

doCheck = false;

makeWrapperArgs = [
"--set PYTHONPATH \".:$PYTHONPATH\""
"--set PIP_IGNORE_INSTALLED 1"
];

meta = with lib; {
description = "Python Development Workflow for Humans";
license = licenses.mit;
Expand Down

0 comments on commit 7f63ecf

Please sign in to comment.