Skip to content

Commit

Permalink
geeqie: xxd is required as build dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
@pSub
pSub committed Nov 5, 2014
1 parent e13f15b commit 852f0bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkgs/applications/graphics/geeqie/default.nix
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, fetchgit, autoconf, automake, libtool, pkgconfig, gtk, libpng, exiv2
, lcms, intltool, gettext, libchamplain, fbida
, lcms, intltool, gettext, libchamplain, fbida, vim
}:

stdenv.mkDerivation rec {
Expand All @@ -22,7 +22,7 @@ stdenv.mkDerivation rec {

buildInputs = [
autoconf automake libtool pkgconfig gtk libpng exiv2 lcms intltool gettext
libchamplain
libchamplain vim
];

postInstall = ''
Expand Down

7 comments on commit 852f0bf

@domenkozar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xxd == vim?

@pSub
Copy link
Member Author

@pSub pSub commented on 852f0bf Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xxd is provided by vim.

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it required? Geeqie seems to build/work fine without it. And in the interest of preventing dependency bloat I'd rather not make Geeqie depend on Vim.

@pSub
Copy link
Member Author

@pSub pSub commented on 852f0bf Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error when trying to build it without the vim dependency:

building ClayRGB1998_icc.h
 echo "/*" > ClayRGB1998_icc.h
 echo " * This file was generated from ClayRGB1998.icc, DO NOT EDIT " >> ClayRGB1998_icc.h
 echo " * http://www.argyllcms.com/ClayRGB1998.zip " >> ClayRGB1998_icc.h
 echo " */ " >> ClayRGB1998_icc.h
 xxd -i ClayRGB1998.icc >> ClayRGB1998_icc.h
/nix/store/j9z585f73bl8i5r0q9pvzwanc7xh5fns-bash-4.2-p51/bin/bash: xxd: command not found
make[2]: *** [ClayRGB1998_icc.h] Error 127
make[2]: Leaving directory `/tmp/nix-build-geeqie-1.2.drv-0/git-export/src'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/tmp/nix-build-geeqie-1.2.drv-0/git-export/src'
make: *** [install-recursive] Error 1
builder for `/nix/store/gywycsi8m05via28y9i12n3rlq1sryna-geeqie-1.2.drv' failed with exit code 2
error: build of `/nix/store/gywycsi8m05via28y9i12n3rlq1sryna-geeqie-1.2.drv' failed

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what platform is that?

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have been caused by the use of fetchgit causing the timestamp of ClayRGB1998.icc to be newer than ClayRGB1998_icc.h, forcing it to be rebuilt. I changed it to use fetchurl which should provide a deterministic timestamp.

@pSub
Copy link
Member Author

@pSub pSub commented on 852f0bf Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, I just noticed some non-deterministic behavior, too. Btw. platform is 64bit linux.

Please sign in to comment.