Skip to content

Commit

Permalink
ghc: Use 8.10.7 bindist for bootstrapping. Fixes musl+integer-simple
Browse files Browse the repository at this point in the history
See #130441.
  • Loading branch information
nh2 committed Sep 20, 2021
1 parent b266503 commit 8ec92c5
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 22 deletions.
4 changes: 0 additions & 4 deletions pkgs/development/compilers/ghc/8.10.7.nix
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,6 @@ stdenv.mkDerivation (rec {
] ++ lib.teams.haskell.members;
timeout = 24 * 3600;
inherit (ghc.meta) license platforms;

# integer-simple builds are broken when GHC links against musl.
# See https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743.
broken = enableIntegerSimple && hostPlatform.isMusl;
};

} // lib.optionalAttrs targetPlatform.useAndroidPrebuilt {
Expand Down
4 changes: 0 additions & 4 deletions pkgs/development/compilers/ghc/8.8.4.nix
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,6 @@ stdenv.mkDerivation (rec {
] ++ lib.teams.haskell.members;
timeout = 24 * 3600;
inherit (ghc.meta) license platforms;

# integer-simple builds are broken when GHC links against musl.
# See https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743.
broken = enableIntegerSimple && hostPlatform.isMusl;
};

dontStrip = (targetPlatform.useAndroidPrebuilt || targetPlatform.isWasm);
Expand Down
4 changes: 0 additions & 4 deletions pkgs/development/compilers/ghc/9.0.1.nix
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,6 @@ stdenv.mkDerivation (rec {
] ++ lib.teams.haskell.members;
timeout = 24 * 3600;
inherit (ghc.meta) license platforms;

# integer-simple builds are broken when GHC links against musl.
# See https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743.
broken = enableIntegerSimple && hostPlatform.isMusl;
};

} // lib.optionalAttrs targetPlatform.useAndroidPrebuilt {
Expand Down
5 changes: 1 addition & 4 deletions pkgs/development/compilers/ghc/9.2.1.nix
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,9 @@ stdenv.mkDerivation (rec {
timeout = 24 * 3600;
inherit (ghc.meta) license platforms;

# integer-simple builds are broken when GHC links against musl.
# See https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743.
# Linker failure on macOS:
# https://gitlab.haskell.org/ghc/ghc/-/issues/19950#note_373726
broken = (enableIntegerSimple && hostPlatform.isMusl)
|| stdenv.hostPlatform.isDarwin;
broken = stdenv.hostPlatform.isDarwin;
hydraPlatforms = lib.remove "x86_64-darwin" ghc.meta.platforms;
};

Expand Down
12 changes: 6 additions & 6 deletions pkgs/top-level/haskell-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ in {
# aarch64 ghc865Binary gets SEGVs due to haskell#15449 or similar
# Musl bindists do not exist for ghc 8.6.5, so we use 8.10.* for them
else if stdenv.isAarch64 || stdenv.targetPlatform.isMusl then
packages.ghc8102BinaryMinimal
packages.ghc8107BinaryMinimal
else
packages.ghc865Binary;
inherit (buildPackages.python3Packages) sphinx;
Expand All @@ -91,7 +91,7 @@ in {
# aarch64 ghc865Binary gets SEGVs due to haskell#15449 or similar
# Musl bindists do not exist for ghc 8.6.5, so we use 8.10.* for them
else if stdenv.isAarch64 || stdenv.isAarch32 || stdenv.targetPlatform.isMusl then
packages.ghc8102BinaryMinimal
packages.ghc8107BinaryMinimal
else
packages.ghc865Binary;
inherit (buildPackages.python3Packages) sphinx;
Expand All @@ -108,19 +108,19 @@ in {
packages.ghc8107BinaryMinimal
# aarch64 ghc8102Binary exceeds max output size on hydra
else if stdenv.isAarch64 || stdenv.isAarch32 then
packages.ghc8102BinaryMinimal
packages.ghc8107BinaryMinimal
else
packages.ghc8102Binary;
packages.ghc8107Binary;
inherit (buildPackages.python3Packages) sphinx;
buildLlvmPackages = buildPackages.llvmPackages_10;
llvmPackages = pkgs.llvmPackages_10;
};
ghc921 = callPackage ../development/compilers/ghc/9.2.1.nix {
# aarch64 ghc8102Binary exceeds max output size on hydra
bootPkgs = if stdenv.isAarch64 || stdenv.isAarch32 then
packages.ghc8102BinaryMinimal
packages.ghc8107BinaryMinimal
else
packages.ghc8102Binary;
packages.ghc8107Binary;
inherit (buildPackages.python3Packages) sphinx;
# Need to use apple's patched xattr until
# https://github.com/xattr/xattr/issues/44 and
Expand Down

0 comments on commit 8ec92c5

Please sign in to comment.