Skip to content

Commit

Permalink
pdal: enable tests
Browse files Browse the repository at this point in the history
  • Loading branch information
imincik committed Dec 19, 2023
1 parent fa5e0f2 commit 956aa78
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion pkgs/development/libraries/pdal/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{ lib, stdenv
, fetchFromGitHub
, fetchpatch
, cmake
, pkg-config
, openscenegraph
Expand Down Expand Up @@ -59,6 +58,8 @@ stdenv.mkDerivation rec {
"-DBUILD_PLUGIN_HDF=ON"
"-DBUILD_PLUGIN_PGPOINTCLOUD=ON"
"-DBUILD_PLUGIN_TILEDB=ON"
"-DWITH_TESTS=ON"
"-DBUILD_PGPOINTCLOUD_TESTS=OFF"

# Plugins can probably not be made work easily:
"-DBUILD_PLUGIN_CPD=OFF"
Expand All @@ -75,6 +76,36 @@ stdenv.mkDerivation rec {
"-DBUILD_PLUGIN_RIVLIB=OFF"
];

doCheck = true;

disabledTests = [
# Tests failing due to TileDB library implementation, disabled also
# by upstream CI.
# See: https://github.com/PDAL/PDAL/blob/bc46bc77f595add4a6d568a1ff923d7fe20f7e74/.github/workflows/linux.yml#L81
"pdal_io_tiledb_writer_test"
"pdal_io_tiledb_reader_test"
"pdal_io_tiledb_time_writer_test"
"pdal_io_tiledb_time_reader_test"
"pdal_io_tiledb_bit_fields_test"
"pdal_io_e57_read_test"
"pdal_io_e57_write_test"
"pdal_io_stac_reader_test"

# Segfault
"pdal_io_hdf_reader_test"

# Failure
"pdal_app_plugin_test"
];

checkPhase = ''
runHook preCheck
# tests are flaky and they seem to fail less often when they don't run in
# parallel
ctest -j 1 --output-on-failure -E '^${lib.concatStringsSep "|" disabledTests}$'
runHook postCheck
'';

meta = with lib; {
description = "PDAL is Point Data Abstraction Library. GDAL for point cloud data";
homepage = "https://pdal.io";
Expand Down

0 comments on commit 956aa78

Please sign in to comment.