-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
diffoscope: Don't propagate build inputs
This reduces the runtime closure size from 297 to 132 MiB.
- Loading branch information
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96d7f35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent of the
propagatedBuildInputs
here was to cause the command-line tools to be added to the PATH by thewrapPythonPackage
. I don't think adding tobuildInputs
has the same effect.96d7f35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dezgeg correct,
wrapPythonPrograms
checkspythonPath
andnix-support/propagated-native-build-inputs
, notbuildInputs
.