-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nodejs: refactor derivations (#19973)
* refactor and clean up the derivation composition * add slim variation: the slim variations configure node without npm. Building node with npm introduces a python runtime depndency through gyp - slim variation makes sense for building small nodejs production images
- Loading branch information
Showing
4 changed files
with
94 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,67 +1,65 @@ | ||
{ stdenv, fetchurl, openssl, python2, zlib, libuv, v8, utillinux, http-parser | ||
, pkgconfig, runCommand, which, libtool | ||
, version | ||
, sha256 ? null | ||
, src ? fetchurl { url = "https://nodejs.org/download/release/v${version}/node-v${version}.tar.xz"; inherit sha256; } | ||
, preBuild ? "" | ||
, extraConfigFlags ? [] | ||
, extraBuildInputs ? [] | ||
, patches ? [], | ||
... | ||
, pkgconfig, runCommand, which, libtool, fetchpatch | ||
, callPackage | ||
, darwin ? null | ||
, enableNpm ? true | ||
}: | ||
|
||
assert stdenv.system != "armv5tel-linux"; | ||
with stdenv.lib; | ||
|
||
let | ||
|
||
deps = { | ||
inherit openssl zlib libuv; | ||
} // (stdenv.lib.optionalAttrs (!stdenv.isDarwin) { | ||
inherit http-parser; | ||
}); | ||
inherit (darwin.apple_sdk.frameworks) CoreServices ApplicationServices; | ||
|
||
sharedConfigureFlags = name: [ | ||
sharedLibDeps = { inherit openssl zlib libuv; } // (optionalAttrs (!stdenv.isDarwin) { inherit http-parser; }); | ||
|
||
sharedConfigureFlags = concatMap (name: [ | ||
"--shared-${name}" | ||
"--shared-${name}-includes=${builtins.getAttr name deps}/include" | ||
"--shared-${name}-libpath=${builtins.getAttr name deps}/lib" | ||
]; | ||
"--shared-${name}-libpath=${getLib sharedLibDeps.${name}}/lib" | ||
]) (builtins.attrNames sharedLibDeps); | ||
|
||
inherit (stdenv.lib) concatMap optional optionals maintainers licenses platforms; | ||
extraConfigFlags = optionals (!enableNpm) [ "--without-npm" ]; | ||
in | ||
|
||
in stdenv.mkDerivation { | ||
rec { | ||
|
||
inherit version src preBuild; | ||
buildInputs = optionals stdenv.isDarwin [ CoreServices ApplicationServices ] | ||
++ [ python2 which zlib libuv openssl ] | ||
++ optionals stdenv.isLinux [ utillinux http-parser ] | ||
++ optionals stdenv.isDarwin [ pkgconfig libtool ]; | ||
|
||
name = "nodejs-${version}"; | ||
configureFlags = sharedConfigureFlags ++ [ "--without-dtrace" ] ++ extraConfigFlags; | ||
|
||
configureFlags = concatMap sharedConfigureFlags (builtins.attrNames deps) ++ [ "--without-dtrace" ] ++ extraConfigFlags; | ||
dontDisableStatic = true; | ||
prePatch = '' | ||
patchShebangs . | ||
sed -i 's/raise.*No Xcode or CLT version detected.*/version = "7.0.0"/' tools/gyp/pylib/gyp/xcode_emulation.py | ||
''; | ||
dontDisableStatic = true; | ||
|
||
postInstall = '' | ||
PATH=$out/bin:$PATH patchShebangs $out | ||
''; | ||
enableParallelBuilding = true; | ||
|
||
patches = patches ++ stdenv.lib.optionals stdenv.isDarwin [ ./no-xcode.patch ]; | ||
passthru.interpreterName = "nodejs"; | ||
|
||
buildInputs = extraBuildInputs | ||
++ [ python2 which zlib libuv openssl ] | ||
++ optionals stdenv.isLinux [ utillinux http-parser ] | ||
++ optionals stdenv.isDarwin [ pkgconfig libtool ]; | ||
setupHook = ./setup-hook.sh; | ||
|
||
enableParallelBuilding = true; | ||
setupHook = ./setup-hook.sh; | ||
|
||
patches = optionals stdenv.isDarwin [ ./no-xcode.patch ]; | ||
|
||
preBuild = optionalString stdenv.isDarwin '' | ||
sed -i -e "s|tr1/type_traits|type_traits|g" \ | ||
-e "s|std::tr1|std|" src/util.h | ||
''; | ||
|
||
prePatch = '' | ||
patchShebangs . | ||
sed -i 's/raise.*No Xcode or CLT version detected.*/version = "7.0.0"/' tools/gyp/pylib/gyp/xcode_emulation.py | ||
''; | ||
|
||
passthru.interpreterName = "nodejs"; | ||
postInstall = '' | ||
PATH=$out/bin:$PATH patchShebangs $out | ||
''; | ||
|
||
meta = { | ||
description = "Event-driven I/O framework for the V8 JavaScript engine"; | ||
homepage = http://nodejs.org; | ||
license = licenses.mit; | ||
maintainers = [ maintainers.goibhniu maintainers.havvy maintainers.gilligan maintainers.cko ]; | ||
platforms = platforms.linux ++ platforms.darwin; | ||
}; | ||
meta = { | ||
description = "Event-driven I/O framework for the V8 JavaScript engine"; | ||
homepage = http://nodejs.org; | ||
license = licenses.mit; | ||
maintainers = with maintainers; [ goibhniu havvy gilligan cko ]; | ||
platforms = platforms.linux ++ platforms.darwin; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,20 @@ | ||
{ stdenv, fetchurl, openssl, python2, zlib, libuv, v8, utillinux, http-parser | ||
, pkgconfig, runCommand, which, libtool | ||
, pkgconfig, runCommand, which, libtool, fetchpatch | ||
, callPackage | ||
, darwin ? null | ||
, enableNpm ? true | ||
}@args: | ||
|
||
import ./nodejs.nix (args // rec { | ||
version = "4.6.0"; | ||
src = fetchurl { | ||
url = "http://nodejs.org/dist/v${version}/node-v${version}.tar.xz"; | ||
sha256 = "1566q1kkv8j30fgqx8sm2h8323f38wwpa1hfb10gr6z46jyhv4a2"; | ||
}; | ||
let | ||
nodejs = import ./nodejs.nix args; | ||
baseName = if enableNpm then "nodejs" else "nodejs-slim"; | ||
in | ||
stdenv.mkDerivation (nodejs // rec { | ||
version = "4.6.0"; | ||
name = "${baseName}-${version}"; | ||
src = fetchurl { | ||
url = "http://nodejs.org/dist/v${version}/node-v${version}.tar.xz"; | ||
sha256 = "1566q1kkv8j30fgqx8sm2h8323f38wwpa1hfb10gr6z46jyhv4a2"; | ||
}; | ||
|
||
preBuild = stdenv.lib.optionalString stdenv.isDarwin '' | ||
substituteInPlace src/util.h \ | ||
--replace "tr1/type_traits" "type_traits" | ||
''; | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters