Skip to content

Commit

Permalink
v8: build with gcc6 on linux
Browse files Browse the repository at this point in the history
doesn't build with gcc 7 due to this issue in upstream code:
https://bugs.chromium.org/p/chromium/issues/detail?id=614289
  • Loading branch information
xeji committed Mar 8, 2018
1 parent 3476508 commit aa5a079
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11595,11 +11595,14 @@ with pkgs;
inherit (python2Packages) python;
};

v8 = callPackage ../development/libraries/v8 {
v8 = callPackage ../development/libraries/v8 ({
inherit (python2Packages) python gyp;
cctools = darwin.cctools;
icu = icu58; # v8-5.4.232 fails against icu4c-59.1
};
} // lib.optionalAttrs stdenv.isLinux {
# doesn't build with gcc7
stdenv = overrideCC stdenv gcc6;
});

v8_static = lowPrio (self.v8.override { static = true; });

Expand Down

0 comments on commit aa5a079

Please sign in to comment.