Skip to content

Commit

Permalink
v8: add version 4.5.107
Browse files Browse the repository at this point in the history
  • Loading branch information
cstrahan committed Oct 23, 2015
1 parent c76f010 commit abf7301
Show file tree
Hide file tree
Showing 5 changed files with 194 additions and 0 deletions.
136 changes: 136 additions & 0 deletions pkgs/development/libraries/v8/4.5.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
{ stdenv, lib, fetchgit, fetchFromGitHub, gyp, readline, python, which, icu
, patchelf, coreutils
, doCheck ? false
}:

assert readline != null;

let
arch = if stdenv.is64bit then "x64" else "ia32";

This comment has been minimized.

Copy link
@ignisf

ignisf Oct 23, 2015

This will be trouble if at any point you'd like to have non-x86 architecture support. Just something to keep in mind.

This is how we cope with this in the libv8 gem: https://github.com/cowboyd/libv8/blob/4.5/ext/libv8/arch.rb
And here are all the supported by v8 arches: https://github.com/v8/v8/blob/4.5.107/Makefile#L241

This comment has been minimized.

Copy link
@cstrahan

cstrahan Oct 23, 2015

Author Contributor

Thanks for the tip. Should be addressed by 4f07c88.

git_url = "https://chromium.googlesource.com";
clangFlag = if stdenv.isDarwin then "1" else "0";

deps = {
"build/gyp" = fetchgit {
url = "${git_url}/external/gyp.git";
rev = "5122240c5e5c4d8da12c543d82b03d6089eb77c5";
sha256 = "0mdrrhmfl4jrdmfrxmg7ywhdf9c7gv2x08fiq955fs9z8kvxqgdx";
};
"third_party/icu" = fetchgit {
url = "${git_url}/chromium/deps/icu.git";
rev = "c81a1a3989c3b66fa323e9a6ee7418d7c08297af";
sha256 = "0xrhig85vpw9hqjrhkxsr69m2xnig2bwmjhylzffrwz0783l7yhw";
};
"buildtools" = fetchgit {
url = "${git_url}/chromium/buildtools.git";
rev = "ecc8e253abac3b6186a97573871a084f4c0ca3ae";
sha256 = "1ccfnj3dp4i0z2bj09zy8aa4x749id6h058qa330li368417jwci";
};
"testing/gtest" = fetchgit {
url = "${git_url}/external/googletest.git";
rev = "23574bf2333f834ff665f894c97bef8a5b33a0a9";
sha256 = "1scyrk8d6xrsqma27q0wdrxqfa2n12k8mi9lfbsm5ivim9sr1d75";
};
"testing/gmock" = fetchgit {
url = "${git_url}/external/googlemock.git";
rev = "29763965ab52f24565299976b936d1265cb6a271";
sha256 = "0n2ajjac7myr5bgqk0x7j8281b4whkzgr1irv5nji9n3xz5i6gz4";
};
"tools/clang" = fetchgit {
url = "${git_url}/chromium/src/tools/clang.git";
rev = "73ec8804ed395b0886d6edf82a9f33583f4a7902";
sha256 = "0p2w4cgj3d4lqa8arss3j86lk0g8zhbbn5pzlcrhy5pl4xphjbk3";
};
};

in

stdenv.mkDerivation rec {
name = "v8-${version}";
version = "4.5.107";

inherit doCheck;

src = fetchFromGitHub {
owner = "v8";
repo = "v8";
rev = version;
sha256 = "0wbzi4rhm4ygsm1k4x0vwfm42z3j8ww6wz7bcvd0m7mqzayn0bw4";
};

postUnpack = ''
${lib.concatStringsSep "\n" (
lib.mapAttrsToList (n: v: ''
mkdir -p $sourceRoot/${n}
cp -r ${v}/* $sourceRoot/${n}
'') deps)}
'';

# Patches pulled from:
# https://github.com/cowboyd/libv8/tree/4.5/patches
patches = lib.optional (!doCheck) ./disable-building-tests.patch ++ [
./fPIC-for-static.patch
./build-standalone-static-library.patch
];

postPatch = ''
sed -i 's,#!/usr/bin/env python,#!${python}/bin/python,' build/gyp_v8
sed -i 's,/bin/echo,${coreutils}/bin/echo,' build/standalone.gypi
sed -i '/CR_CLANG_REVISION/ d' build/standalone.gypi
'';

configurePhase = ''
PYTHONPATH="tools/generate_shim_headers:$PYTHONPATH" \
PYTHONPATH="$(toPythonPath ${gyp}):$PYTHONPATH" \
build/gyp_v8 \
-f make \
--generator-output="out" \
-Dflock_index=0 \
-Dclang=${clangFlag} \
-Dv8_enable_i18n_support=1 \
-Duse_system_icu=1 \
-Dcomponent=shared_library \
-Dconsole=readline \
-Dv8_target_arch=${arch} \
-Dv8_use_external_startup_data=0
'';

nativeBuildInputs = [ which ];
buildInputs = [ readline python icu patchelf ];

buildFlags = [
"LINK=g++"
"-C out"
"builddir=$(CURDIR)/Release"
"BUILDTYPE=Release"
];

enableParallelBuilding = true;

# the `libv8_libplatform` target is _only_ built as a static library,
# and is expected to be statically linked in when needed.
# see the following link for further commentary:
# https://github.com/cowboyd/therubyracer/issues/391
installPhase = ''
install -vD out/Release/d8 "$out/bin/d8"
install -vD out/Release/mksnapshot "$out/bin/mksnapshot"
${if stdenv.isDarwin then ''
install -vD out/Release/lib.target/libv8.dylib "$out/lib/libv8.dylib"
install_name_tool -change /usr/local/lib/libv8.dylib $out/lib/libv8.dylib -change /usr/lib/libgcc_s.1.dylib ${stdenv.cc.cc}/lib/libgcc_s.1.dylib $out/bin/d8
install_name_tool -id $out/lib/libv8.dylib -change /usr/lib/libgcc_s.1.dylib ${stdenv.cc.cc}/lib/libgcc_s.1.dylib $out/lib/libv8.dylib
'' else ''
install -vD out/Release/lib.target/libv8.so "$out/lib/libv8.so"
''}
mkdir -p "$out/include"
cp -vr include/*.h "$out/include"
cp -vr include/libplatform "$out/include"
cp -v out/Release/*.a "$out/lib"
'';

meta = with lib; {
description = "Google's open source JavaScript engine";
maintainers = with maintainers; [ cstrahan ];
platforms = with platforms; linux;
license = licenses.bsd3;
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/build/standalone.gypi b/build/standalone.gypi
index b6519c4..ef9e7c5 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -373,6 +373,9 @@
}],
],
'target_conditions': [
+ ['_type=="static_library"', {
+ 'standalone_static_library': 1,
+ }],
['v8_code == 0', {
'defines!': [
'DEBUG',
27 changes: 27 additions & 0 deletions pkgs/development/libraries/v8/disable-building-tests.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
diff --git a/Makefile b/Makefile
index 9761265..80169b2 100644
--- a/Makefile
+++ b/Makefile
@@ -248,8 +248,6 @@ NACL_ARCHES = nacl_ia32 nacl_x64
GYPFILES = third_party/icu/icu.gypi third_party/icu/icu.gyp \
build/shim_headers.gypi build/features.gypi build/standalone.gypi \
build/toolchain.gypi build/all.gyp build/mac/asan.gyp \
- test/cctest/cctest.gyp \
- test/unittests/unittests.gyp tools/gyp/v8.gyp \
tools/parser-shell.gyp testing/gmock.gyp testing/gtest.gyp \
buildtools/third_party/libc++abi/libc++abi.gyp \
buildtools/third_party/libc++/libc++.gyp samples/samples.gyp \
diff --git a/build/all.gyp b/build/all.gyp
index 4aeb507..1ff2c7a 100644
--- a/build/all.gyp
+++ b/build/all.gyp
@@ -10,8 +10,6 @@
'dependencies': [
'../samples/samples.gyp:*',
'../src/d8.gyp:d8',
- '../test/cctest/cctest.gyp:*',
- '../test/unittests/unittests.gyp:*',
],
'conditions': [
['component!="shared_library"', {

13 changes: 13 additions & 0 deletions pkgs/development/libraries/v8/fPIC-for-static.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 7670e5b..230518c 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -205,7 +205,7 @@
[ 'visibility=="hidden" and v8_enable_backtrace==0', {
'cflags': [ '-fvisibility=hidden' ],
}],
- [ 'component=="shared_library"', {
+ [ 'component=="shared_library" or component=="static_library" and (v8_target_arch=="x64" or v8_target_arch=="arm64")', {
'cflags': [ '-fPIC', ],
}],
],
4 changes: 4 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8410,6 +8410,10 @@ let
inherit (pythonPackages) gyp;
};

v8_4_5 = callPackage ../development/libraries/v8/4.5.nix {
inherit (pythonPackages) gyp;
};

v8 = callPackage ../development/libraries/v8 {
inherit (pythonPackages) gyp;
};
Expand Down

0 comments on commit abf7301

Please sign in to comment.