Skip to content

Commit

Permalink
stdenv/make-derivation: don't hide broken packages
Browse files Browse the repository at this point in the history
This behavior ended up breaking the handleEvalIssue functionality by hiding those packages. So something like this:

$ nix-env -iA nixpkgs.zoom-us

would silently fail, without telling the user how to fix it! Regardless, this "bug" should be handled in Nix - not Nixpkgs.

Fixes #38952.
  • Loading branch information
matthewbauer committed Jan 27, 2019
1 parent 39fdfd0 commit ae16dd1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkgs/stdenv/generic/make-derivation.nix
Expand Up @@ -180,9 +180,7 @@ rec {
"__impureHostDeps" "__propagatedImpureHostDeps"
"sandboxProfile" "propagatedSandboxProfile"])
// {
# A hack to make `nix-env -qa` and `nix search` ignore broken packages.
# TODO(@oxij): remove this assert when something like NixOS/nix#1771 gets merged into nix.
name = assert validity.handled; computedName + lib.optionalString
name = computedName + lib.optionalString
# Fixed-output derivations like source tarballs shouldn't get a host
# suffix. But we have some weird ones with run-time deps that are
# just used for their side-affects. Those might as well since the
Expand Down

0 comments on commit ae16dd1

Please sign in to comment.