Skip to content

Commit

Permalink
icu_57: init at 57.1 for LibreOffice Still
Browse files Browse the repository at this point in the history
  • Loading branch information
7c6f434c committed Mar 9, 2017
1 parent 8a91ac5 commit b5485da
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 0 deletions.
64 changes: 64 additions & 0 deletions pkgs/development/libraries/icu/57.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
{ stdenv, fetchurl, fetchpatch, fixDarwinDylibNames }:

let
pname = "icu4c";
version = "57.1";
in
stdenv.mkDerivation ({
name = pname + "-" + version;

src = fetchurl {
url = "http://download.icu-project.org/files/${pname}/${version}/${pname}-"
+ (stdenv.lib.replaceChars ["."] ["_"] version) + "-src.tgz";
sha256 = "10cmkqigxh9f73y7q3p991q6j8pph0mrydgj11w1x6wlcp5ng37z";
};

outputs = [ "out" "dev" ];
outputBin = "dev";

# FIXME: This fixes dylib references in the dylibs themselves, but
# not in the programs in $out/bin.
buildInputs = stdenv.lib.optional stdenv.isDarwin fixDarwinDylibNames;

postUnpack = ''
sourceRoot=''${sourceRoot}/source
echo Source root reset to ''${sourceRoot}
'';

# This pre/postPatch shenanigans is to handle that the patches expect
# to be outside of `source`.
prePatch = ''
pushd ..
'';
postPatch = ''
popd
'';

patches = [
];

preConfigure = ''
sed -i -e "s|/bin/sh|${stdenv.shell}|" configure
'';

configureFlags = "--disable-debug" +
stdenv.lib.optionalString (stdenv.isFreeBSD || stdenv.isDarwin) " --enable-rpath";

# remove dependency on bootstrap-tools in early stdenv build
postInstall = stdenv.lib.optionalString stdenv.isDarwin ''
sed -i 's/INSTALL_CMD=.*install/INSTALL_CMD=install/' $out/lib/icu/${version}/pkgdata.inc
'';

postFixup = ''moveToOutput lib/icu "$dev" '';

enableParallelBuilding = true;

meta = with stdenv.lib; {
description = "Unicode and globalization support library";
homepage = http://site.icu-project.org/;
maintainers = with maintainers; [ raskin urkud ];
platforms = platforms.all;
};
} // (if stdenv.isArm then {
patches = [ ./0001-Disable-LDFLAGSICUDT-for-Linux.patch ];
} else {}))
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7782,6 +7782,8 @@ with pkgs;
hyena = callPackage ../development/libraries/hyena { };

icu = callPackage ../development/libraries/icu { };
# Needed for LibreOffice Still as of 5.2.6.2
icu_57 = callPackage ../development/libraries/icu/57.nix { };

id3lib = callPackage ../development/libraries/id3lib { };

Expand Down

2 comments on commit b5485da

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented on b5485da Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LibreOffice 5.2.6.2 won't build with ICU 58 ?
ICU 57.x has two known vulnerabilities : http://site.icu-project.org/security

EDIT: ah saw #23662 after writing this. Nevermind...

@7c6f434c
Copy link
Member Author

@7c6f434c 7c6f434c commented on b5485da Mar 9, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.