Skip to content

Commit

Permalink
grafana: skip a test that started failing
Browse files Browse the repository at this point in the history 
It's weird but this single test started failing in this staging-next
iteration, on all four 64-bit platforms.
I thought this will be better than not having any grafana,
as it's only a single test and our .tests still build.
  • Loading branch information
@vcunat
vcunat committed Apr 12, 2023
1 parent 4bcb462 commit cdefbd2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkgs/servers/monitoring/grafana/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ buildGoModule rec {
sed -i -e '/it should change folder successfully and return correct result/{N;s/$/\nt.Skip();/}'\
pkg/services/libraryelements/libraryelements_patch_test.go
# TODO: investigate?
substituteInPlace pkg/tests/api/alerting/api_alertmanager_test.go \
--replace TestIntegrationAMConfigAccess DontTestIntegrationAMConfigAccess
# main module (github.com/grafana/grafana) does not contain package github.com/grafana/grafana/scripts/go
rm -r scripts/go
Expand Down

8 comments on commit cdefbd2

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some of the grafana.meta.maintainers can have a look? @offlinehacker @fpletz @WilliButz @globin @Ma27 @Frostman (e.g. retest your setup early, at least)

@Ma27
Copy link
Member

@Ma27 Ma27 commented on cdefbd2 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it fail reproducibly? Grafana tends to have some flaky tests, but normally I catch them while updating...

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was retried many times on different machines. And it regressed on all four platforms on Hydra simultaneously.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've linked a log, as it takes time to get there:
https://hydra.nixos.org/build/215012481/nixlog/7/tail

@Ma27
Copy link
Member

@Ma27 Ma27 commented on cdefbd2 Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat this test depended on the 31st March to be in the future, not in the past: grafana/grafana@8ef2fb4 %)

Fix got merged in, so we can simply remove this hack when updating.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, it feels like we get some of these at least every other month in nixpkgs.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let me open it already #226277

@vcunat
Copy link
Member Author

@vcunat vcunat commented on cdefbd2 Apr 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the upstream fix.

Please sign in to comment.