Skip to content

Commit

Permalink
python3Packages.dask: fix sandboxed builds
Browse files Browse the repository at this point in the history
Importing dask.dataframe in a sandboxed build results in a TypeError like
this:

  File "/nix/store/nv60iri29bia4szhhcvsdxgsci4wxvp6-python3.8-dask-2021.03.0/lib/python3.8/site-packages/dask/dataframe/io/csv.py", line 392, in <module>
    AUTO_BLOCKSIZE = auto_blocksize(TOTAL_MEM, CPU_COUNT)
  File "/nix/store/nv60iri29bia4szhhcvsdxgsci4wxvp6-python3.8-dask-2021.03.0/lib/python3.8/site-packages/dask/dataframe/io/csv.py", line 382, in auto_blocksize
    blocksize = int(total_memory // cpu_count / memory_factor)
  TypeError: unsupported operand type(s) for //: 'int' and 'NoneType'

This occurs because dask.dataframe has a non-deterministic component which
generates an automatic chunk-size based on system information.

This went unnoticed because the dask tests were disabled.

Changes:
- add a patch making the chunk-size inference more robust
- re-enable the tests

Resolves #120307
  • Loading branch information
nbren12 committed Apr 24, 2021
1 parent c21475e commit ceeaf2d
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion pkgs/development/python-modules/dask/default.nix
@@ -1,6 +1,7 @@
{ lib
, bokeh
, buildPythonPackage
, fetchpatch
, fetchFromGitHub
, fsspec
, pytestCheckHook
Expand Down Expand Up @@ -42,7 +43,7 @@ buildPythonPackage rec {
distributed
];

doCheck = false;
doCheck = true;

checkInputs = [
pytestCheckHook
Expand All @@ -52,6 +53,16 @@ buildPythonPackage rec {

dontUseSetuptoolsCheck = true;

patches = [
# dask dataframe cannot be imported in sandboxed builds
# See https://github.com/dask/dask/pull/7601
(fetchpatch {
url = "https://github.com/dask/dask/commit/9ce5b0d258cecb3ef38fd844135ad1f7ac3cea5f.patch";
sha256 = "sha256-1EVRYwAdTSEEH9jp+UOnrijzezZN3iYR6q6ieYJM3kY=";
name = "fix-dask-dataframe-imports-in-sandbox.patch";
})
];

postPatch = ''
# versioneer hack to set version of github package
echo "def get_versions(): return {'dirty': False, 'error': None, 'full-revisionid': None, 'version': '${version}'}" > dask/_version.py
Expand All @@ -66,8 +77,13 @@ buildPythonPackage rec {
disabledTests = [
"test_annotation_pack_unpack"
"test_annotations_blockwise_unpack"
# this test requires features of python3Packages.psutil that are
# blocked in sandboxed-builds
"test_auto_blocksize_csv"
];

pythonImportsCheck = [ "dask.dataframe" "dask" "dask.array" ];

meta = with lib; {
description = "Minimal task scheduling abstraction";
homepage = "https://dask.org/";
Expand Down

0 comments on commit ceeaf2d

Please sign in to comment.