Skip to content

Commit

Permalink
sort plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
@jagajaga
jagajaga committed Nov 20, 2014
1 parent 4f3190f commit f54f79e
Showing 1 changed file with 731 additions and 675 deletions.

11 comments on commit f54f79e

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagajaga You've been involved in the "vim-plugins" update. But why did you sort the plugin names? This clearly shows me that you don't understand the derivation generation at all. It is important to keep plugins which get derived automatically from vim-pi separate so that all of those can be updated in one go because updating single derivations is too much work (IMHO). Do you agree? So would you be fine If I created a bug report soon which reverts this patch keeping the changes made after it ? If you don't know what I'm talking about contact me on irc, please so that we can discuss

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again you've dropped important comments you think are useless: all

# unkown by vim-pi ?
# not git version in vim-pi

lines without taking notes in your comment about why you do it (without asking the one who did added those commits).
Let me explain: the first comment says it should be added to vim-pi so that they can be derived automatically. The second comment says that it looks like the versions are different so again this should be resolved in vim-pi eg by adding the github url in order to update plugins more easily in the future.

Please get in touch so that we can resolve this

@jagajaga
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, I would like to say that

    call nix#ExportPluginsForNix({
    \  'path_to_nixpkgs': '/etc/nixos/nixpkgs',
    \  'cache_file': '/tmp/vim2nix-cache',
    \  'names': [
    \    "vim-addon-syntax-checker",
    \    "vim-addon-other"
          ....
    \ ],
    \ })

doesn't work well. Indeed it doesn't fetch revisions and shas. Maybe I'm doing smth wrong.

I've wrote a script (https://gist.github.com/jagajaga/3c7ba009ee6756e12978) that helps me to create a drv.
Based on a result of that I've sorted plugins to easily collect them, update via my script and edit this default.nix.
Maybe you show me the real work how you update these drvns, and after that we will merge out ideas.
And also the reason why I've sorted them - is just my honest opinion to make it look nicer.

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its hard to understand what "path_to_nixpkgs" means? I agree hat I should improve error reporting.
The code I wrote automatically fetches dependencies (as known by VAM (addon-info.json files)). Thus looking for all derivations to replace is tiresome compared to "delete everything generated by nix#Export.. and reinsert everything" which is pretty fast. You're right that sorting by name is "prettier". So maybe I should improve the code generating the nix derivations to sort by key? Assuming that replacing all derivations at once is fastest best we can do is have this { A .. Z # now vam#nixExport .. generated start: A .. Z} which means having two sections within which the plugins are sorted. To make this clearer to users we could refactor and have two files as well. Would this satisfy you ?

@jagajaga
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Your solution ir really nice. And sorry for my wrong using of nix#ExportPluginsForNix :)
Hope we won't have misunderstandings futher.

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed you've found a bug by my not checking exit code of System in nix.vim (fixed). Pull request for nixpkgs is here: #5212

The next time try to contact the author/maintainer if something obvious is wrong (such as empty sha256)
Can you really imagine me wanting to spend time on such repetitive tasks after having started vim-pi and VAM? :-) You're welcome. Please provide feedback about the patch above.

Things should be easier now. In the end we all want the same: less work and more fun

@jagajaga
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I copy (or move) documentation from vim-utils.nix to a wiki page?

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think its making anything better because devs will miss it and it can get out of sync. Can you help me understand why documentation shoud be put on the wiki instead?

@jagajaga
Copy link
Member Author

@jagajaga jagajaga commented on f54f79e Dec 3, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arguments are the same. There is another option: the nixpks manual. Doing some testing is more important. Eg I notice that webapi runs "make" which fails - make should not be run at all.

@MarcWeber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fixed as well. About documentation I've asked on the mailinglist.

Please sign in to comment.