-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
coqPackages.fiat_HEAD: Update 2016-10-24 -> 2018-02-27
- Loading branch information
Showing
1 changed file
with
8 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5f71c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwiegley Was this actually tested? It seems that in the current state, this fails because it doesn't fetch submodules. With
deepClone = true
andsha256 = "04zpazhznnykwgrx1r7rz3cxbpv2nd4l9gfcwhxg9xc7fc18qg0q"
(with the submodules it is indeed a different hash) it seems like the Makefile fails because it contains a call togit submodule
(andgit
is not available) which somehow ends up installing.v
files instead of.vo
.BTW @JasonGross: that's the second time that I'm bothered by the fact that the fiat Makefile contains a call to git. That's really bad practice IMO.
f5f71c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zimmi48 Not tested well enough. I'll roll it back.
f5f71c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. However, I'm not actively developing fiat (and don't have plans to in the near future), so I'm disinclined to go mucking around with the build system. (I'm also bottlenecked on time, right now.) What's the reason you're packaging fiat?
f5f71c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not. I only stumbled upon this commit. As for @jwiegley, I suppose he uses it 😃
f5f71c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a new version of
fiat
, btw, calledfiat-core
, which contains only the core elements. This version is not publicly released yet, and I think it still relies on Git, so it's worth fixing that in the Nix build when that happens. Stay tuned.