Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: Include patch or change replaygain backend #10376

Closed
Profpatsch opened this issue Oct 13, 2015 · 3 comments
Closed

beets: Include patch or change replaygain backend #10376

Profpatsch opened this issue Oct 13, 2015 · 3 comments

Comments

@Profpatsch
Copy link
Member

In the current version, the replaygain backend used by nixpkgs has a bug that crashes beets.

A fix is available here and needs to be cherry-picked.
Bear in mind that this patch doesn’t handle the error, it only skips the files where it happens.

Alternatively it might make sense to switch to a different backend, there are others available, documented in https://beets.readthedocs.org/en/latest/plugins/replaygain.html

cc @aszlig @pjones @domenkozar
@pjones
Copy link
Contributor

pjones commented Oct 13, 2015

Sounds like we should switch to GStreamer.

domenkozar referenced this issue in beetbox/beets Oct 14, 2015
@sampsyo
Fix #1592 again: wrap title_gain in handler
225ba28
@aszlig aszlig closed this as completed in d7307d8 Oct 25, 2015
@Profpatsch
Copy link
Member Author

@aszlig friendly reminder that beetbox/beets@225ba28 is not yet fixed, the error is only caught and logged.
We should either fix the error upstream or switch to a different backend.

@aszlig
Copy link
Member

aszlig commented Oct 26, 2015

Mhm, we have bs1770gain since 7ab8dde, so it might make sense to switch to it as the default backend instead. Especially since the upstream project maintainer tends to move away from audiotools.

kamilchm pushed a commit to kamilchm/nixpkgs that referenced this issue Oct 29, 2015
@aszlig @kamilchm
beets: 1.3.14 -> 1.3.15
9c14a3d 
Introduces a new plugin called "badfiles", which helps to scan for
corruption within the music collection. I've added this to
pluginsWithoutDeps and sorted the list.

Full upstream changelog can be found here:

https://github.com/sampsyo/beets/releases/tag/v1.3.15

This fixes NixOS#10376 via beetbox/beets@225ba28.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig added a commit that referenced this issue Dec 18, 2015
@aszlig
beets: Use bs1770gain by default for replaygain
68c504f 
After trying with a dozen files, it seems the bs1770gain backend is much
more reliable than the audiotools backend and especially does a better
job (well, compared to audiotools which either does doing nothing at all
or throws an exception) when used on alboms that contain different
sample rates/sizes.

Additionally, we already had a few issues regarding the audiotools
backend, even to the extent that @sampsyco almost wanted to drop it
upstream (see sampsyco/beets#1342).

Also related issues are #10376 and beetbox/beets#1592.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
@mdorman mdorman mentioned this issue Feb 19, 2017
Merged
7 tasks
globin pushed a commit that referenced this issue Feb 20, 2017
@mdorman @globin
beets: enable gstreamer support
dc19ba7 
So this was suggested as [long ago as October, 2015](#10376 (comment)).

Despite being fairly ignorant of the nix Python support, I decided
that I really wanted this; this change brings in what I believe are
the necessary components---I have, at least, successfully run `beet
replaygain` and `beet bpd`---but it may not do it in the best way; I'm
happy to consider input on that front.

I can at least state that all three changes are necessary---leave any
one of them out and gstreamer support doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjones @aszlig @Profpatsch