-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-cpufreq: init at 1.5.1 #106985
auto-cpufreq: init at 1.5.1 #106985
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Result of 1 package built:
Add |
# copy script manually | ||
cp ${src}/scripts/cpufreqctl.sh $out/bin/cpufreqctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to install()
it seems to me that the installation is incomplete (missed the font install and polkit policy). Doesn't this make this program miss some features 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this script was copied from this repo. Those files don't even exist in anywhere in auto-cpufreq, but they do exist in the other project.
Result of 1 package built:
|
@SuperSandro2000 added and squashed. |
This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC. Result of 1 package built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
I wanted to use auto-cpufreq and so do others AdnanHodzic/auto-cpufreq#130
Things done
Create the auto-cpufreq package and add myself to maintainers
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)There really needs to be a NixOS module, but I will work on it after this gets merged.
Here is a temporary solution to get the systemd service: