Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: use assert for checking goPackagePath #113046

Merged
merged 1 commit into from
Feb 15, 2021
Merged

buildGoModule: use assert for checking goPackagePath #113046

merged 1 commit into from
Feb 15, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 13, 2021

Motivation for this change

I should have used an assert in #107085 as it's more idiomatic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
buildGoModule: use assert for checking goPackagePath
a82d76b 
also remove a `disabled` leftover from 26117ed
@kalbasit
Copy link
Member

@GrahamcOfBorg build pet

@kalbasit kalbasit merged commit bb419e0 into NixOS:master Feb 15, 2021
@zowoq zowoq deleted the gomod-assert branch February 15, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @kalbasit