I think fetchgit is broken

[copumpkin]

Commit 2cf7069 seems to have broken my calls to fetchgit:

Bash complains that it cannot execute the binary file. I noticed this when building gitAndTools.hub against nixpkgs 84b3af1. Removing @peti's change makes it work again.

[peti]

How do you call fetchgit and what error message do you get?

[peti]

gitAndTools.hub compiles fine for me in the current unstable channel at b1dca6c.

[hrdinka]

It is broken for me as well. I am building NixOS on top of the current master. For me it fails for gnulib with:
/nix/store/33k6qnz10brkf66lr6yav6bcl4bhy5z0-bash-4.3-p42/bin/bash: /nix/store/33k6qnz10brkf66lr6yav6bcl4bhy5z0-bash-4.3-p42/bin/bash: cannot execute binary file

I guess that it uses /nix/*/bash /nix/*/bash as shell for calling nix-prefetch-git. I think this happens because as soon as you make the value of fetcher a string it will be executed with bash. The command does call bash itself so bash tries to call bash.

[peti]

Please try version b89514e and let me know if that patch didn't do the trick.

[hrdinka]

👍 thanks that fixed it.