syslinux: fix missing mtools dependency

[jgillich]

closes #11472

[mention-bot]

By analyzing the blame information on this pull request, we identified @wkennington, @edolstra and @dezgeg to be potential reviewers

[dezgeg]

This doesn't seem to actually make mtools a runtime dependency: nix-store -q --tree /nix/store/k31kkci0f5w9kxa4pr7q97zd6c6zdz11-syslinux-2015-11-09 | grep mtools returns no hits.

The references to mcopy are:

$ strings /nix/store/k31kkci0f5w9kxa4pr7q97zd6c6zdz11-syslinux-2015-11-09/bin/syslinux | grep mcopy                                                                                                                                                           21:52:22
mcopy -D o -D O -o - s:/ldlinux.sys
mcopy -D o -D O -o - s:/ldlinux.c32

So you'd have to either patch the absolute path to mcopy there, or use wrapProgram.

[jgillich]

@dezgeg Ok I'm still rebuilding because of bash and don't know how long it will take, can you check if this one is correct? Thanks!

[jgillich]

$ nix-store -q --tree /nix/store/k4zh2spsaax99y9zjv3smdkwvnr00pbk-syslinux-2015-11-09/ | grep mtools
+---/nix/store/7d5cxpcvkygsfmvrys7sz3ywj8bj6b9r-mtools-4.0.18
|   +---/nix/store/7d5cxpcvkygsfmvrys7sz3ywj8bj6b9r-mtools-4.0.18 [...]

Should be all good now.

[jgillich]

@jagajaga Mind taking a look? Thanks!

[jagajaga]

I'm not a syslinux guy :(
Cc @Phreedom @wkennington

[wkennington]

Lgtm
On Thu, Dec 10, 2015 at 10:27 PM Arseniy Seroka notifications@github.com
wrote:

I'm not a syslinux guy :(
Cc @Phreedom https://github.com/Phreedom @wkennington
https://github.com/wkennington

—
Reply to this email directly or view it on GitHub
#11549 (comment).

[jgillich]

Somebody still has to hit merge. :)