-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closure size WIP #11597
Closure size WIP #11597
Conversation
I am and @lethalman decided to postpone this PR before master will be merged to closure-size, and I rebase stuff on it. |
Ping. I pushed a tested version of closure-size with new staging in it. (All packages I use do build.) |
And, in the meantime subversion started to build again, so it's possible some parts of this PR won't be needed anymore (and/or will conflict). |
On Wed, Jan 20, 2016 at 10:51:22AM -0800, Vladimír Čunát wrote:
I am not sure, if it was common problem, or it unbuildable on |
No, at the time of filing this PR I did experience svn build problems, but I do not anymore (for the same attribute). |
On Wed, Jan 20, 2016 at 11:54:37AM -0800, Vladimír Čunát wrote:
Can you tell what problems, and how you fix them? |
It didn't build, but I don't remember the error exactly (it was months ago) and I don't know how it got fixed. Maybe I did pushe something to fix it or someone else did, but I just don't remember anymore :-) |
On Wed, Jan 20, 2016 at 01:14:07PM -0800, Vladimír Čunát wrote:
Or it just come from cache. |
Probably the subversion problem was caused by GCC 5 (which closure-size had but no longer seems to have) which had some changes in that area. |
On Mon, Jan 25, 2016 at 03:51:01PM -0800, Tuomas Tynkkynen wrote:
In my experiments it fixed by adding
But not sure if it correct solution. |
On Mon, Jan 25, 2016 at 03:51:01PM -0800, Tuomas Tynkkynen wrote:
Some comment taken from my own unstaged commit:
|
The gcc switch back was done and explained in 9d13434. It didn't occur to me as a possible reason why it builds again. |
2ffefb9
to
5b86d46
Compare
5b86d46
to
6102094
Compare
Updated branch. |
@vcunat This one can be merged ;) Next broken things: qtbase (via postgres's libpq and iodbc), and packages which contain only manpages (stdmanpage) -- but haven't any ideas how to fix them. Any other packages which I can to fix/test to make whole closure-size merged? |
|
The |
On Thu, Jan 28, 2016 at 04:39:18AM -0800, Vladimír Čunát wrote:
I just see iodbc related error upper in log before libpq's one. |
I expect it's an optional dependency that is never fulfilled on any of our branches. |
On Thu, Jan 28, 2016 at 06:16:14AM -0800, Vladimír Čunát wrote:
Good. |
I'm updating merge blockers (in my opinion) at the top of that PR #7701. |
Fix qtile, fvwm and subversion