Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-install broken by new nix #116938

Closed
blaggacao opened this issue Mar 19, 2021 · 0 comments · Fixed by #116807
Closed

nixos-install broken by new nix #116938

blaggacao opened this issue Mar 19, 2021 · 0 comments · Fixed by #116807

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Mar 19, 2021 •
edited

nixpkgs/nixos/modules/installer/tools/nixos-install.sh

Line 128 in e30d87f

flake=$(nix "${flakeFlags[@]}" flake info --json "${extraBuildFlags[@]}" "${lockFlags[@]}" -- "$flake" | jq -r .url)

this line is broken by NixOS/nix#4613

nix flake list-inputs + nix flake info = nix flake metadata
@veprbl veprbl linked a pull request Mar 19, 2021 that will close this issue
nixUnstable: pre20210308_1c0e3e4 -> pre20210317_8a5203d, nixos-rebuild: nix flake info -> nix flake metadata #116807
Merged
10 tasks
@ahmedelgabri ahmedelgabri mentioned this issue Mar 21, 2021
Closed
bors bot added a commit to divnix/digga that referenced this issue Mar 22, 2021
@bors
Merge #202
870897a 
202: iso: avoid systemd service startup r=nrdxp a=blaggacao

fixes #194
alternative to #197

# Manual Tests


<details>
<summary>was unrelated</summary>

- [ ] `flk install NixOS --impure` correctly onto `/mnt` ❎ (looks like no profile is present)

Issue: #204
Upstream Issue: NixOS/nixpkgs#116938

</details>

- [x] acceptable build time / closure size ca 850MB (for a simple base OS) ✔️ 
- [x] local profile with `cage` service is disabled, that is: boots into terminal ✔️ 
- [x] success: air gapped / offline devshell enter ✔️ 
- [ ] failure: aire gapped target install: &larr; non blocking bonus item ❎ 
```console
$ flk install POS
warning: you don't have internet access; disabling some network-dependent features
building the flake in path:/iso/devos?narHash=sha265-...
warning: you don't have internet access; disabling some network-dependent features
error: unable to download 'https://api.github.com/repos/NixOS/nixpkgs/df8e3...': Couldn't resolve host name (6)
```

&rarr; detailed rationale in the commit messages

:heart: @Pacman99 for the excellent and detailed discussions in #197 and the may ideas, suggestions and code.

Co-authored-by: David Arnold <dar@xoe.solutions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@blaggacao