Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link in pkgs/development/tools/documentation/gi-docgen/default.nix #118728

Closed
nomeata opened this issue Apr 7, 2021 · 2 comments
Closed

Dead link in pkgs/development/tools/documentation/gi-docgen/default.nix #118728

nomeata opened this issue Apr 7, 2021 · 2 comments
Labels
0.kind: bug

Comments

@nomeata
Copy link
Contributor

nomeata commented Apr 7, 2021

In 17e4508 @jtojnar fetches a patch from https://gitlab.gnome.org/ebassi/gi-docgen/commit/d65ed2e4827c4129d26e3c1df9a48054b4e72c50.patch, but that URL seems dead now (maybe a rebase there).
@jtojnar
Copy link
Member

jtojnar commented Apr 7, 2021

Sorry, that should have been https://gitlab.gnome.org/jtojnar/gi-docgen/commit/d65ed2e4827c4129d26e3c1df9a48054b4e72c50.patch. Must have pushed a wrong commit.

This patch is not necessary on master and the upcoming 0.0.3 version.

@jtojnar jtojnar closed this as completed in e3c239f Apr 7, 2021
@nomeata
Copy link
Contributor Author

nomeata commented Apr 7, 2021

Thanks!

cideM pushed a commit to cideM/nixpkgs that referenced this issue Apr 9, 2021
@jtojnar @cideM
gi-docgen: fix patch URL
de172cc 
Fixes: NixOS#118728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nomeata @jtojnar