gupnp-igd build flaky #119288
Comments
|
I've not run into this, but I don't love flaky tests. Since this passes as long as the system isn't under load... I suppose the best way is to disable the test? Because increasing the timeout doesn't seem like a good long-term fix. |
|
If (for example) the test takes 25-35 seconds, and the timeout is 30 seconds, increasing the timeout to 300 seconds would be a perfectly reasonable long-term fix IMO. Why wouldn't it be? TImeouts are there to catch things that have got stuck, not to test that something is fast, so they don't need to be anywhere close to how long something actually takes, as long as they're short enough that they'll catch stuck processes promptly. |
|
Although, on my 2012 laptop, under load, I can't reproduce this (but have reproduced it on a powerful server). On the laptop it takes 5 seconds normally and 7 under load. So I think maybe it's more likely that it is just getting stuck. |
|
I reported the issue upstream, so they hopefully can fix it and we can enable the check again. |
|
When it get stuck, should we report it upstream, so it can get fixed and we can enable the check again?
Be my guest, all though in my experience it's basically impossible to
put together an actionable bug report for an issue like this.
|
|
When they would be able to reproduce it, they can investigate themselves. I have no idea what this is about. |
davidak
added
2.status: wait-for-upstream
Describe the bug
the build of gupnp-igd seem to be flaky.
i have seen the build fail now for the second time in a few days, but when i try again, it works
the issue seem to be a TIMEOUT.
To Reproduce
Steps to reproduce the behavior:
that heppened in a system rebuild where many things are build and the system is under load
when i build just the one package, it works
[davidak@gaming:~/code/nixpkgs]$ nix-build . -A gupnp_igdExpected behavior
build should always succeed
Additional context
build from staging at fea3171
Notify maintainers
cc @maxeaubrey who updated it last
Metadata
"x86_64-linux"Linux 5.11.11, NixOS, 21.05pre281538.9e377a6ce42 (Okapi)yesyesnix-env (Nix) 2.3.10"home-manager-20.09, nixos-21.05pre281538.9e377a6ce42, nixos-hardware, nixos-unstable-21.05pre281538.9e377a6ce42"/nix/var/nix/profiles/per-user/root/channels/nixosMaintainer information:
The text was updated successfully, but these errors were encountered: