-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gupnp-igd: disable tests #121051
gupnp-igd: disable tests #121051
Conversation
Can you just set it to false and add a comment above with the think to #119288? |
Result of 16 packages marked as broken and skipped:
1 package failed to build:190 packages skipped due to time constraints:
82 packages built successfully:
1 suggestion:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 12 packages marked as broken and skipped:
1 package failed to build:241 packages skipped due to time constraints:
83 packages built successfully:
1 suggestion:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
Would just a comment on its own work for you? We could have |
Only runs one test, and that test seems to get stuck sometimes. Fixes: NixOS#119288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation for this change
Only runs one test, and that test seems to get stuck sometimes.
Related issue #119288
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)