Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gupnp-igd: disable tests #121051

Merged
merged 1 commit into from
Apr 29, 2021
Merged

gupnp-igd: disable tests #121051

merged 1 commit into from
Apr 29, 2021

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Apr 28, 2021

Motivation for this change

Only runs one test, and that test seems to get stuck sometimes.

Related issue #119288

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented Apr 28, 2021

Can you just set it to false and add a comment above with the think to #119288?

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 28, 2021

Result of nixpkgs-review pr 121051 at ef454c43 run on aarch64-linux 1

16 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • gnunet-gtk
  • gtkd
  • libsForQt512.dragon
  • libsForQt512.kamoso
  • libsForQt512.kdenlive
  • libsForQt512.phonon-backend-gstreamer
  • libsForQt514.kdenlive
  • odpdown
  • ...
1 package failed to build:
190 packages skipped due to time constraints:
  • adapta-gtk-theme
  • almanah
  • apostrophe
  • astroid
  • balsa
  • banking
  • bookworm
  • bubblemail
  • caerbannog
  • calls
  • ...
82 packages built successfully:
  • aravis
  • audio-recorder
  • baresip
  • brasero
  • brasero-original
  • byzanz
  • cawbird
  • enlightenment.rage
  • evince (gnome3.evince)
  • farstream
  • gajim
  • gcompris
  • gmrender-resurrect
  • gnome-network-displays
  • gscrabble
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-plugins-bad
  • gst_all_1.gst-rtsp-server
  • gst_all_1.gst-vaapi
  • gupnp-igd
  • libnice
  • libsForQt5.dragon (libsForQt515.dragon ,plasma5Packages.dragon)
  • libsForQt5.kamoso (libsForQt515.kamoso ,plasma5Packages.kamoso)
  • libsForQt5.phonon-backend-gstreamer (libsForQt515.phonon-backend-gstreamer ,plasma5Packages.phonon-backend-gstreamer)
  • libsForQt514.dragon
  • libsForQt514.kamoso
  • libsForQt514.phonon-backend-gstreamer
  • mailnag
  • mopidy-iris
  • mopidy-local
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-musicbox-webclient
  • mopidy-scrobbler
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-subidy
  • mopidy-tunein
  • mopidy-youtube
  • pantheon.elementary-camera
  • pantheon.elementary-music
  • pantheon.elementary-videos
  • parlatype
  • picard
  • pidgin
  • pidgin-carbons
  • pidgin-latex
  • pidgin-mra
  • pidgin-msn-pecan
  • pidgin-opensteamworks
  • pidgin-osd
  • pidgin-otr
  • pidgin-sipe
  • pidgin-skypeweb
  • pidgin-window-merge
  • pidgin-xmpp-receipts
  • pithos
  • pitivi
  • purple-discord
  • purple-facebook
  • purple-hangouts
  • purple-lurch
  • purple-matrix
  • purple-plugin-pack
  • purple-slack
  • purple-vk-plugin
  • purple-xmpp-http-upload
  • python38Packages.kivy
  • python39Packages.kivy
  • qt-video-wlr
  • qutebrowser
  • run-scaled
  • skype4pidgin
  • sound-juicer
  • telegram-purple
  • telepathy-farstream
  • telepathy-haze
  • toxprpl
  • xfce.parole
  • xpra
  • yaxg
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/gupnp-igd/default.nix:53:3:

       |
    53 |   meta = with lib; {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121051 at ef454c43 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • gnunet-gtk
  • libsForQt512.dragon
  • libsForQt512.kamoso
  • libsForQt512.kdenlive
  • libsForQt512.phonon-backend-gstreamer
  • libsForQt514.kdenlive
  • odpdown
  • openmodelica
  • ...
1 package failed to build:
241 packages skipped due to time constraints:
  • adapta-gtk-theme
  • almanah
  • apostrophe
  • areca
  • astroid
  • aws-workspaces
  • azureus
  • balsa
  • banking
  • birdfont
  • ...
83 packages built successfully:
  • aravis
  • audio-recorder
  • baresip
  • brasero
  • brasero-original
  • byzanz
  • cawbird
  • enlightenment.rage
  • evince (gnome3.evince)
  • farstream
  • gajim
  • gcompris
  • gmrender-resurrect
  • gnome-network-displays
  • gscrabble
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-plugins-bad
  • gst_all_1.gst-rtsp-server
  • gst_all_1.gst-vaapi
  • gupnp-igd
  • libnice
  • libsForQt5.dragon (libsForQt515.dragon ,plasma5Packages.dragon)
  • libsForQt5.kamoso (libsForQt515.kamoso ,plasma5Packages.kamoso)
  • libsForQt5.phonon-backend-gstreamer (libsForQt515.phonon-backend-gstreamer ,plasma5Packages.phonon-backend-gstreamer)
  • libsForQt514.dragon
  • libsForQt514.kamoso
  • libsForQt514.phonon-backend-gstreamer
  • mailnag
  • mopidy-iris
  • mopidy-local
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-musicbox-webclient
  • mopidy-scrobbler
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-spotify-tunigo
  • mopidy-subidy
  • mopidy-tunein
  • mopidy-youtube
  • pantheon.elementary-camera
  • pantheon.elementary-music
  • pantheon.elementary-videos
  • parlatype
  • picard
  • pidgin
  • pidgin-carbons
  • pidgin-latex
  • pidgin-mra
  • pidgin-msn-pecan
  • pidgin-opensteamworks
  • pidgin-osd
  • pidgin-otr
  • pidgin-sipe
  • pidgin-skypeweb
  • pidgin-window-merge
  • pidgin-xmpp-receipts
  • pithos
  • pitivi
  • purple-discord
  • purple-facebook
  • purple-hangouts
  • purple-lurch
  • purple-matrix
  • purple-plugin-pack
  • purple-slack
  • purple-vk-plugin
  • purple-xmpp-http-upload
  • python38Packages.kivy
  • python39Packages.kivy
  • qt-video-wlr
  • qutebrowser
  • run-scaled
  • skype4pidgin
  • sound-juicer
  • telegram-purple
  • telepathy-farstream
  • telepathy-haze
  • toxprpl
  • xfce.parole
  • xpra
  • yaxg
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/gupnp-igd/default.nix:53:3:

       |
    53 |   meta = with lib; {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@alyssais
Copy link
Member Author

Would just a comment on its own work for you? We could have # doCheck = true; below to show what it was referring to. I don't like manually re-applying defaults.

Only runs one test, and that test seems to get stuck sometimes.

Fixes: NixOS#119288
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidak davidak merged commit 5cf7af2 into NixOS:master Apr 29, 2021
@alyssais alyssais deleted the gupnp-igd branch April 29, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants