Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eternity-engine: 3.43.02 -> 4.02.00 #129832

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

canndrew
Copy link
Contributor

Motivation for this change

Update eternity engine to the most recent version. Some new WADs require the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 10, 2021

Result of nixpkgs-review pr 129832 at da8514e9 run on x86_64-linux 1

1 package built successfully:
  • eternity
2 suggestions:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/games/eternity-engine/default.nix:27:5:

       |
    27 |     license = lib.licenses.gpl3;
       |     ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/games/eternity-engine/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 129832 at da8514e9 run on aarch64-linux 1

1 package built successfully:
  • eternity

@SuperSandro2000
Copy link
Member

@ofborg build eternity-engine

@SuperSandro2000 SuperSandro2000 merged commit 0c7cc64 into NixOS:master Dec 5, 2021
@wegank wegank mentioned this pull request Nov 4, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants